Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirm elixir_euler_blob_shockcapturing_mortar.jl #309

Merged
merged 1 commit into from
Nov 9, 2020
Merged

confirm elixir_euler_blob_shockcapturing_mortar.jl #309

merged 1 commit into from
Nov 9, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Nov 9, 2020

I've confirmed examples/2d/elixir_euler_blob_shockcapturing_mortar.jl and assimilated the extended tests into the normal tests. After more than 1000 time steps, I get

julia> verify_taal("examples/2d/parameters_euler_blob_shockcapturing_mortar.toml",
                   "examples/2d/elixir_euler_blob_shockcapturing_mortar.jl",
                   t_end=10.0)
[...]
================================================================================
L2 (Taam - Taal):
4-element StaticArrays.SArray{Tuple{4},Float64,1,4} with indices SOneTo(4):
 3.608224830031759e-16
 9.2148511043888e-15
 3.608224830031759e-16
 2.3092638912203256e-14
================================================================================
Linf (Taam - Taal):
4-element StaticArrays.SArray{Tuple{4},Float64,1,4} with indices SOneTo(4):
 8.881784197001252e-15
 2.4300561562995426e-12
 3.455014052633487e-13
 1.3528733688872308e-11
================================================================================

That's okay, I think.

Closes #243.

@ranocha ranocha requested a review from sloede November 9, 2020 06:33
@ranocha ranocha linked an issue Nov 9, 2020 that may be closed by this pull request
Assimilate extended tests into normal tests #243
Closed
sloede
sloede approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If the answer to my question is yes, feel free to merge.

@ranocha ranocha merged commit 3c094db into msl/sync-taal-taam Nov 9, 2020
@ranocha ranocha deleted the remove_extended_tests branch November 9, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede approved these changes

Assignees
No one assigned
Labels
taal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assimilate extended tests into normal tests
2 participants
@ranocha @sloede