Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent example names #320

Merged
merged 7 commits into from
Nov 11, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Nov 11, 2020

Closes #244. I cancelled the Travis CI build since we don't need it here.

@ranocha ranocha requested a review from sloede November 11, 2020 06:44
@ranocha ranocha mentioned this pull request Nov 11, 2020
50 tasks
@ranocha ranocha linked an issue Nov 11, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #320 (7f11db8) into dev (406ccc2) will decrease coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #320      +/-   ##
==========================================
- Coverage   89.38%   88.34%   -1.05%     
==========================================
  Files          84       84              
  Lines       13381    13381              
==========================================
- Hits        11961    11821     -140     
- Misses       1420     1560     +140     
Flag Coverage Δ
unittests 88.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/semidiscretization_euler_gravity.jl 78.83% <ø> (ø)
src/timedisc/timedisc.jl 82.11% <ø> (ø)
src/timedisc/timedisc_euler_gravity.jl 61.68% <ø> (-28.98%) ⬇️
src/run_euler_gravity.jl 81.65% <0.00%> (-11.84%) ⬇️
src/amr/amr.jl 86.00% <0.00%> (-8.00%) ⬇️
src/solvers/dg/2d/amr.jl 88.46% <0.00%> (-7.70%) ⬇️
src/equations/2d/compressible_euler.jl 84.50% <0.00%> (-7.40%) ⬇️
src/equations/2d/hyperbolic_diffusion.jl 82.72% <0.00%> (-3.67%) ⬇️
src/solvers/dg/2d/dg.jl 91.89% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406ccc2...b0d37c5. Read the comment docs.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With one typo fixed, this can be merged.

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@ranocha ranocha merged commit 36c053b into trixi-framework:dev Nov 11, 2020
@ranocha ranocha mentioned this pull request Nov 17, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to name elixir files
2 participants