Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Taam #331

Merged
merged 15 commits into from
Nov 13, 2020
Merged

Remove Taam #331

merged 15 commits into from
Nov 13, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Nov 12, 2020

😱
Let's see whether I moved all methods that are still necessary correctly.

@ranocha ranocha added the taal label Nov 12, 2020
@ranocha ranocha requested a review from sloede November 12, 2020 16:04
@ranocha ranocha changed the title Remove Taam 😱 Remove Taam Nov 12, 2020
@ranocha ranocha mentioned this pull request Nov 12, 2020
50 tasks
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #331 (12e68b0) into dev (c3261d0) will decrease coverage by 0.06%.
The diff coverage is 91.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #331      +/-   ##
==========================================
- Coverage   88.57%   88.51%   -0.07%     
==========================================
  Files          90       74      -16     
  Lines       13765     8793    -4972     
==========================================
- Hits        12193     7783    -4410     
+ Misses       1572     1010     -562     
Flag Coverage Δ
unittests 88.51% <91.74%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-dynamics/elixir_eulergravity_jeans_instability.jl 90.00% <ø> (ø)
src/Trixi.jl 100.00% <ø> (ø)
src/auxiliary/containers.jl 88.70% <ø> (ø)
src/equations/1d/compressible_euler.jl 83.26% <ø> (-3.83%) ⬇️
src/equations/1d/linear_scalar_advection.jl 80.32% <ø> (+1.22%) ⬆️
src/equations/2d/compressible_euler.jl 91.95% <ø> (+7.45%) ⬆️
src/equations/2d/ideal_glm_mhd.jl 92.47% <ø> (-0.15%) ⬇️
src/equations/2d/linear_scalar_advection.jl 77.50% <ø> (+0.75%) ⬆️
src/equations/3d/compressible_euler.jl 92.00% <ø> (-0.15%) ⬇️
src/equations/3d/hyperbolic_diffusion.jl 79.72% <0.00%> (-3.26%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3261d0...12e68b0. Read the comment docs.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hendrik, this PR is... HORRIBLE 😱 🙀 🤯

You deleted all the nice and clean code!!1!!!!111!!!!one!!!1!!!eleven!11

Frankly, there's not much I can do here. I left a few comments here and there, but my spirit is crushed, so...

image
😱

ranocha and others added 4 commits November 12, 2020 18:07
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@ranocha ranocha requested a review from sloede November 12, 2020 17:17
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😭

@sloede sloede merged commit 99519ac into dev Nov 13, 2020
@sloede sloede deleted the remove_taam branch November 13, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants