Fix clang-tidy findings #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2020 12:44
Found during static analysis with clang-tidy-9.
Found during static analysis with clang-tidy-9. Reviewer: Note that this is a compiler-specific attribute. Please check if it's available on all supported platforms.
|
Interesting! Unfortunately Travis doesn't pass anymore, both the GCC and the clang build steps fail. |
added 2 commits
May 8, 2020 12:56
Found during static analysis with clang-tidy-9.
Found during static analysis with clang-tidy-9.
wolframroesler
force-pushed
the
fix-clang-tidy-findings
branch
from
a7b06ae
to
37c6cee
Compare
|
Seems our code has diverged from yours. Fixed it. |
|
Awesome, thank you for fixing it so quick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor non-functional changes to remove warnings reported by the clang-tidy-9 static checker.