-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gdb: Replace operator new / operator new[]
If xmalloc fails allocating memory, usually because something tried a huge allocation, like xmalloc(-1) or some such, GDB asks the user what to do: .../src/gdb/utils.c:1079: internal-error: virtual memory exhausted. A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) If the user says "n", that throws a QUIT exception, which is caught by one of the multiple CATCH(RETURN_MASK_ALL) blocks somewhere up the stack. The default implementations of operator new / operator new[] call malloc directly, and on memory allocation failure throw std::bad_alloc. Currently, if that happens, since nothing catches it, the exception escapes out of main, and GDB aborts from unhandled exception. This patch replaces the default operator new variants with versions that, just like xmalloc: #1 - Raise an internal-error on memory allocation failure. #2 - Throw a QUIT gdb_exception, so that the exact same CATCH blocks continue handling memory allocation problems. A minor complication of #2 is that operator new can _only_ throw std::bad_alloc, or something that extends it: void* operator new (std::size_t size) throw (std::bad_alloc); That means that if we let a gdb QUIT exception escape from within operator new, the C++ runtime aborts due to unexpected exception thrown. So to bridge the gap, this patch adds a new gdb_quit_bad_alloc exception type that inherits both std::bad_alloc and gdb_exception, and throws _that_. If we decide that we should be catching memory allocation errors in fewer places than all the places we currently catch them (everywhere we use RETURN_MASK_ALL currently), then we could change operator new to throw plain std::bad_alloc then. But I'm considering such a change as separate matter from this one -- it'd make sense to do the same to xmalloc at the same time, for instance. Meanwhile, this allows using new/new[] instead of xmalloc/XNEW/etc. without losing the "virtual memory exhausted" internal-error safeguard. Tested on x86_64 Fedora 23. gdb/ChangeLog: 2016-09-23 Pedro Alves <palves@redhat.com> * Makefile.in (SFILES): Add common/new-op.c. (COMMON_OBS): Add common/new-op.o. (new-op.o): New rule. * common/common-exceptions.h: Include <new>. (struct gdb_quit_bad_alloc): New type. * common/new-op.c: New file. gdb/gdbserver/ChangeLog: 2016-09-23 Pedro Alves <palves@redhat.com> * Makefile.in (SFILES): Add common/new-op.c. (OBS): Add common/new-op.o. (new-op.o): New rule.
- Loading branch information
Showing
6 changed files
with
132 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* Replace operator new/new[], for GDB, the GNU debugger. | ||
| Copyright (C) 2016 Free Software Foundation, Inc. | ||
| This file is part of GDB. | ||
| This program is free software; you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by | ||
| the Free Software Foundation; either version 3 of the License, or | ||
| (at your option) any later version. | ||
| This program is distributed in the hope that it will be useful, | ||
| but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| GNU General Public License for more details. | ||
| You should have received a copy of the GNU General Public License | ||
| along with this program. If not, see <http://www.gnu.org/licenses/>. */ | ||
|
|
||
| #include "common-defs.h" | ||
| #include "host-defs.h" | ||
| #include <new> | ||
|
|
||
| /* Override operator new / operator new[], in order to internal_error | ||
| on allocation failure and thus query the user for abort/core | ||
| dump/continue, just like xmalloc does. We don't do this from a | ||
| new-handler function instead (std::set_new_handler) because we want | ||
| to catch allocation errors from within global constructors too. | ||
| Note that C++ implementations could either have their throw | ||
| versions call the nothrow versions (libstdc++), or the other way | ||
| around (clang/libc++). For that reason, we replace both throw and | ||
| nothrow variants and call malloc directly. */ | ||
|
|
||
| void * | ||
| operator new (std::size_t sz) | ||
| { | ||
| /* malloc (0) is unpredictable; avoid it. */ | ||
| if (sz == 0) | ||
| sz = 1; | ||
|
|
||
| void *p = malloc (sz); /* ARI: malloc */ | ||
| if (p == NULL) | ||
| { | ||
| /* If the user decides to continue debugging, throw a | ||
| gdb_quit_bad_alloc exception instead of a regular QUIT | ||
| gdb_exception. The former extends both std::bad_alloc and a | ||
| QUIT gdb_exception. This is necessary because operator new | ||
| can only ever throw std::bad_alloc, or something that extends | ||
| it. */ | ||
| TRY | ||
| { | ||
| malloc_failure (sz); | ||
| } | ||
| CATCH (ex, RETURN_MASK_ALL) | ||
| { | ||
| do_cleanups (all_cleanups ()); | ||
|
|
||
| throw gdb_quit_bad_alloc (ex); | ||
| } | ||
| END_CATCH | ||
| } | ||
| return p; | ||
| } | ||
|
|
||
| void * | ||
| operator new (std::size_t sz, const std::nothrow_t&) | ||
| { | ||
| /* malloc (0) is unpredictable; avoid it. */ | ||
| if (sz == 0) | ||
| sz = 1; | ||
| return malloc (sz); /* ARI: malloc */ | ||
| } | ||
|
|
||
| void * | ||
| operator new[] (std::size_t sz) | ||
| { | ||
| return ::operator new (sz); | ||
| } | ||
|
|
||
| void* | ||
| operator new[] (std::size_t sz, const std::nothrow_t&) | ||
| { | ||
| return ::operator new (sz, std::nothrow); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters