There may exist a bug in ECMWF_convert_to_ROMS.py

[LI-EM-Rj]

Thanks for this great project, but I encountered a small issue while using the code.
In the ECMWF_convert_to_ROMS.py, line 99, function write_to_ROMS_netcdf_file is defined and netcdf_file is used as a parameter, which gives the name of the netcdf file to be written in line 120.
However, in line 120,the code is netcdf_roms_filename = f"{out_filename[0:-3]}_roms.nc", which use out_filename instead of netcdf_file, causing the problem: NameError: name 'out_filename' is not defined.
I wonder if the code may need to be modified. Looking for reply. Thanks

[trondkr]

This should be fixed now

[LI-EM-Rj]

I also have another suggestion.
When I try to use the forcing file generated, I was told that "swrad_time" is missing.
So I add: vnc.time = metadata['time_name'] while writing variable to the final netcdf file, and it works.
Maybe we can add this to avoid user to find the solution theirselves, for this little problem has been reported in ROMS Forum by others.

[trondkr]

Hi. Yes. Could you make pull request and I’ll add bit? Thanks. T

…

On 30 Jul 2022, 00:27 -0700, LI-EM-Rj ***@***.***>, wrote: I also have another suggestion. When I try to use the forcing file generated, I was told that "swrad_time" is missing. So I add: vnc.time = metadata['time_name'] while writing variable to the final netcdf file, and it works. Maybe we can add this to avoid user to find the solution theirselves, for this little problem has been reported in ROMS Forum by others. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>