feat(net) : optimize the isIdle method #5921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimize the isIdle method. refer to issue #5913
Why are these changes required?
During the block synchronization process, if the broadcast list has not been received, the synchronization may fail. The detailed process is as follows:
chain inventory
message, setfetchFlag
to true.startFetchSyncBlock
method to fetch the block, and at this time,fetchFlag
will be set to false.advInvRequest
is not empty at this time,peer.isIdle()
returns false, so after this scheduling, the block is not obtained, butfetchFlag
is set to false and cannot be set back, so the block cannot be obtained later.This PR has been tested by:
Follow up
Extra details