Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Adds defaultRichTextElements prop #119

Merged
merged 4 commits into from
May 6, 2023
Merged

[Feature] Adds defaultRichTextElements prop #119

merged 4 commits into from
May 6, 2023

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented May 2, 2023

🤖 Resolves #118.

👋 Introduction

This PR adds defaultRichTextElements to the IntlProvider component as a prop.

🎩 Credit

h/t to @esizer for a sound mind!

🧪 Testing

Assist reviewers with steps they can take to test that the PR does what it says it does.

  1. npm run storybook
  2. Navigate to Rich Text Elements story
  3. Observe the rich text elements of the string

📸 Screenshot

Screen Shot 2023-05-02 at 13 19 21

@mnigh mnigh mentioned this pull request May 2, 2023
Closed
@floriangosse
Copy link
Member

This looks great. Thanks. :)

@floriangosse floriangosse merged commit 4ecc002 into truffls:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing defaultRichTextElements i18n configuration prop
2 participants
@mnigh @floriangosse