Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using canonicalized path to launch cmd from hook results in incorrect working directory #889

Closed
bicarlsen opened this issue Oct 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bicarlsen
Copy link
Contributor

bicarlsen commented Oct 21, 2024

On Windows, if a hook's command is cmd it results in the error

'\\?\C:\Users\me\Documents\my_app'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported. Defaulting to Windows directory.

This is being caused by hooks setting the current directory which are canonicalized.

@ctron
Copy link
Collaborator

ctron commented Oct 21, 2024

Thanks for reporting this. Could you come up with a PR for this?

@ctron
Copy link
Collaborator

ctron commented Oct 28, 2024

Closed by #891

@ctron ctron closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants