feat(schema): add test for unsupported decorator types

tsedio · Sep 8, 2022 · 56f3452 · 56f3452
1 parent d94c1db
commit 56f3452
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/specs/schema/src/decorators/operations/deprecated.spec.ts b/packages/specs/schema/src/decorators/operations/deprecated.spec.ts
@@ -1,5 +1,6 @@
 import {Deprecated, getSpec, OperationPath, Returns, SpecTypes} from "@tsed/schema";
 import {QueryParams} from "@tsed/platform-params";
+import {catchError} from "@tsed/core";
 
 describe("Deprecated", () => {
   it("should store metadata (swagger)", () => {
@@ -208,4 +209,14 @@ describe("Deprecated", () => {
       }
     });
   });
+  it("should throw an error when the decorator is as static func decorator", () => {
+    const error = catchError(() => {
+      class Model {
+        @Deprecated(true)
+        static myStaticFunc() {}
+      }
+    });
+
+    expect(error?.message).toEqual("Deprecated cannot be used as method.static decorator on Model.myStaticFunc");
+  });
 });
diff --git a/packages/specs/schema/src/decorators/operations/deprecated.ts b/packages/specs/schema/src/decorators/operations/deprecated.ts
@@ -1,4 +1,4 @@
-import {decorateMethodsOf, DecoratorTypes, UnsupportedDecoratorType} from "@tsed/core";
+import {decorateMethodsOf, decoratorTypeOf, DecoratorTypes, UnsupportedDecoratorType} from "@tsed/core";
 import {JsonEntityFn} from "../common/jsonEntityFn";
 import {JsonPropertyStore} from "../../domain/JsonPropertyStore";
 import {JsonParameterStore} from "../../domain/JsonParameterStore";
@@ -27,7 +27,7 @@ import {JsonParameterStore} from "../../domain/JsonParameterStore";
  */
 export function Deprecated(deprecated: boolean = true) {
   return JsonEntityFn((store, args) => {
-    switch (store.decoratorType) {
+    switch (decoratorTypeOf(args)) {
       case DecoratorTypes.METHOD:
         store.operation!.deprecated(deprecated);
         break;