Duplicate PO: allow units delivered/rec to be set to 0

[Luke1982]

corebos/modules/PurchaseOrder/EditView.php

Line 76 in fafe91c

$PO_associated_prod = getAssociatedProducts($currentModule, $focus);

In my opinion this should be default, but for the sake of backwards compatibility we can do it through a GV. I think we should set the units delivered/received to zero when duplicating a PO. You typically do that to re-place a previous order at a supplier so the units can never be received at that point. @joebordes could you advise on how you would like this to be done?

[joebordes]

What I would like to see would be:

• global variable Inventory_PODuplicate_SetUnits0: 0|1 (boolean), default 0 (= not active)
• when the variable is set and we are duplicating:
  • we set the Quantity to 0
  • show, in parenthesis, next to the quantity input and in a smaller letter the original quantity

How does that sound?

[Luke1982]

The only thing I would change is the GV name. It reads like it applies to the qty of the line, I think it would be better to use something like 'delrec' in the name. Other than that, great!

[joebordes]

How about Inventory_PODuplicate_SetQty0 as the column header is set to Qty?

[Luke1982]

To be clear: I'm not talking about the Qty, I'm talking about the units delivered/received that you can switch on through the masterdetail businessmap.

[joebordes]

I don't know what that is. Can you upload a screenshot?

[Luke1982]

I mean this field

[Luke1982]

@joebordes Do you have some time to take a look here?

[joebordes]

I wasn't going to look into this, but...

b755093
3d5bfe8

I added two directives to the map

        <defaultvalue>0</defaultvalue>
        <duplicatevalue>0</duplicatevalue>

let me know how it goes

[Luke1982]

Wow, that's cool. But are you manipulating the quantity field, or the units delivered/received?

[joebordes]

the default/duplicate values are defined in the map for the fields you expose

[Luke1982]

I'm sorry, I don't understand what you mean

[joebordes]

<map>
  <originmodule>PurchaseOrder</originmodule>
  <targetmodule>InventoryDetails</targetmodule>
  <linkfields>
  <originfield>lineitem_id</originfield>
  <targetfield>lineitem_id</targetfield>
  </linkfields>
  <sortfield>sequence_no</sortfield>
  <detailview>
    <fields>
      <field>
        <fieldtype>corebos</fieldtype>
        <fieldname>units_delivered_received</fieldname>
        <editable>1</editable>
        <mandatory>1</mandatory>
        <hidden>0</hidden>
      </field>
      <field>
        <fieldtype>corebos</fieldtype>
        <fieldname>cf_795</fieldname>
        <editable>1</editable>
        <mandatory>1</mandatory>
        <hidden>0</hidden>

<defaultvalue>0</defaultvalue>
<duplicatevalue>0</duplicatevalue>

      </field>
      <field>
        <fieldtype>corebos</fieldtype>
        <fieldname>cost_price</fieldname>
        <editable>1</editable>
        <mandatory>1</mandatory>
        <hidden>0</hidden>
      </field>
   </fields>
  </detailview>
</map>

[Luke1982]

Ah yes, got it