Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruments are measuring with cover closed #198

Closed
waterdropchen opened this issue Nov 5, 2023 · 2 comments
Closed

Instruments are measuring with cover closed #198

waterdropchen opened this issue Nov 5, 2023 · 2 comments
Assignees
Labels
scope:opus status:implemented has been implemented in some dev branch

Comments

@waterdropchen
Copy link

waterdropchen commented Nov 5, 2023

Descriptions

Instruments are measuring with cover closed, at either sunny or cloudy conditions. Possible solution: check whether measurements are still onging when the cover is closed. If yes, stop the measurements.

Pyra Version

4.0.8

OPUS Version

No response

CamTracker Version

No response

Windows Version

No response

Your config.json file

No response

@dostuffthatmatters
Copy link
Member

dostuffthatmatters commented Nov 5, 2023

Thank you for the report.

This should be fixed by #184.

EDIT: this message was wrong (see below).

@dostuffthatmatters dostuffthatmatters added the status:implemented has been implemented in some dev branch label Nov 5, 2023
@dostuffthatmatters dostuffthatmatters added status:in-progress is being work on in some dev branch and removed status:implemented has been implemented in some dev branch labels Nov 7, 2023
@dostuffthatmatters
Copy link
Member

Thank you for the report.

This should be fixed by #184.

Hi @waterdropchen,

I did not read the issue carefully. It does make a lot of sense that we do not start the Opus Macro until the cover is open. The commit fb1d811 implements this logic now: If we have info on the cover angle, only run Opus, when the cover is open. Hence, this works with and without the TUM Enclosure.

Best,
Moritz

@dostuffthatmatters dostuffthatmatters added status:implemented has been implemented in some dev branch and removed status:in-progress is being work on in some dev branch labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:opus status:implemented has been implemented in some dev branch
Projects
None yet
Development

No branches or pull requests

2 participants