Don't show incorrect mail address info on legacy plans #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
force-pushed
the
6540-fix-mail-address-info-message
branch
3 times, most recently
from
62df259 to
34ec53e
Compare
murilopereirame
requested changes
Feb 23, 2024
| @@ -78,7 +77,7 @@ export class MailAddressTable implements Component<MailAddressTableAttrs> { | |||
| "{totalAmount}": model.aliasCount.totalAliases, | |||
| }), | |||
| ), | |||
| m(".small.mt-s", lang.get("mailAddressInfo_msg")), | |||
| model.aliasLimitIncludesCustomDomains() ? null : m(".small.mt-s", lang.get("mailAddressInfo_msg")), | |||
There was a problem hiding this comment.
We shouldn't completely remove the message because this part Disabled email addresses can be reassigned to another user or mailbox within your account. still valid for legacy and new plans. Talking with @kibhub , we agreed that maybe be worth to have two different keys, one for Legacy plans and another the new ones
There was a problem hiding this comment.
I feel like this should've been put in as acceptance criteria on the original issue, but OK.
paw-hub
force-pushed
the
6540-fix-mail-address-info-message
branch
from
34ec53e to
bc91b24
Compare
It is not true that legacy plans can have unlimited custom domains. Make it not display anything here to prevent confusion. Fixes #6540
Avoid any potential future issues with hardcoding the list here.
paw-hub
force-pushed
the
6540-fix-mail-address-info-message
branch
from
bc91b24 to
6ad6c66
Compare
murilopereirame
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not true that legacy plans can have unlimited custom domains. Make it not display anything here to prevent confusion.
Fixes #6540