From 34d745540d690086cdfc4ce648963f9acdc56bdb Mon Sep 17 00:00:00 2001
From: XhmikosR <xhmikosr@gmail.com>
Date: Mon, 6 Nov 2017 02:23:36 +0200
Subject: [PATCH] Minor Sass consistency changes. (#24677)

* use `background-color` instead of the shorthand
* use `outline: 0` consistently
* fix transform order
* remove quotes from `SFMono-Regular`
---
 scss/_close.scss        | 2 +-
 scss/_custom-forms.scss | 2 +-
 scss/_dropdown.scss     | 2 +-
 scss/_navbar.scss       | 2 +-
 scss/_reboot.scss       | 2 +-
 scss/_variables.scss    | 4 ++--
 scss/mixins/_forms.scss | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/scss/_close.scss b/scss/_close.scss
index 897d4868443a..4271bc720b2a 100644
--- a/scss/_close.scss
+++ b/scss/_close.scss
@@ -22,7 +22,7 @@
 // stylelint-disable property-no-vendor-prefix, selector-no-qualifying-type
 button.close {
   padding: 0;
-  background: transparent;
+  background-color: transparent;
   border: 0;
   -webkit-appearance: none;
 }
diff --git a/scss/_custom-forms.scss b/scss/_custom-forms.scss
index a521dbdc9445..643dab6ff6ef 100644
--- a/scss/_custom-forms.scss
+++ b/scss/_custom-forms.scss
@@ -148,7 +148,7 @@
 
   &:focus {
     border-color: $custom-select-focus-border-color;
-    outline: none;
+    outline: 0;
     @include box-shadow($custom-select-focus-box-shadow);
 
     &::-ms-value {
diff --git a/scss/_dropdown.scss b/scss/_dropdown.scss
index 19edfca7a782..a9d4cfed2e4a 100644
--- a/scss/_dropdown.scss
+++ b/scss/_dropdown.scss
@@ -89,7 +89,7 @@
   color: $dropdown-link-color;
   text-align: inherit; // For `<button>`s
   white-space: nowrap; // prevent links from randomly breaking onto new lines
-  background: none; // For `<button>`s
+  background-color: transparent; // For `<button>`s
   border: 0; // For `<button>`s
 
   @include hover-focus {
diff --git a/scss/_navbar.scss b/scss/_navbar.scss
index 6b023e82e400..64766eb768a3 100644
--- a/scss/_navbar.scss
+++ b/scss/_navbar.scss
@@ -109,7 +109,7 @@
   padding: $navbar-toggler-padding-y $navbar-toggler-padding-x;
   font-size: $navbar-toggler-font-size;
   line-height: 1;
-  background: transparent; // remove default button style
+  background-color: transparent; // remove default button style
   border: $border-width solid transparent; // remove default button style
   @include border-radius($navbar-toggler-border-radius);
 
diff --git a/scss/_reboot.scss b/scss/_reboot.scss
index f98a7194785e..62b3a666506a 100644
--- a/scss/_reboot.scss
+++ b/scss/_reboot.scss
@@ -71,7 +71,7 @@ body {
 //
 // Credit: https://github.com/suitcss/base
 [tabindex="-1"]:focus {
-  outline: none !important;
+  outline: 0 !important;
 }
 
 
diff --git a/scss/_variables.scss b/scss/_variables.scss
index 895dfc22f1b3..a8e4392ab6ab 100644
--- a/scss/_variables.scss
+++ b/scss/_variables.scss
@@ -221,7 +221,7 @@ $transition-collapse:         height .35s ease !default;
 
 // stylelint-disable value-keyword-case
 $font-family-sans-serif:      -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol" !default;
-$font-family-monospace:       "SFMono-Regular", Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace !default;
+$font-family-monospace:       SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace !default;
 $font-family-base:            $font-family-sans-serif !default;
 // stylelint-enable value-keyword-case
 
@@ -416,7 +416,7 @@ $input-height-sm:                       calc(#{$input-height-inner-sm} + #{$inpu
 $input-height-inner-lg:                 ($font-size-lg * $input-btn-line-height-lg) + ($input-btn-padding-y-lg * 2) !default;
 $input-height-lg:                       calc(#{$input-height-inner-lg} + #{$input-height-border}) !default;
 
-$input-transition:                      border-color ease-in-out .15s, box-shadow ease-in-out .15s !default;
+$input-transition:                      border-color .15s ease-in-out, box-shadow .15s ease-in-out !default;
 
 $form-text-margin-top:                  .25rem !default;
 
diff --git a/scss/mixins/_forms.scss b/scss/mixins/_forms.scss
index 5d822a440d39..6c171aae8cf0 100644
--- a/scss/mixins/_forms.scss
+++ b/scss/mixins/_forms.scss
@@ -15,7 +15,7 @@
     color: $input-focus-color;
     background-color: $input-focus-bg;
     border-color: $input-focus-border-color;
-    outline: none;
+    outline: 0;
     // Avoid using mixin so we can pass custom focus shadow properly
     @if $enable-shadows {
       box-shadow: $input-box-shadow, $input-focus-box-shadow;