Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glyphicon-euro incorrectly named #14867

Closed
hpoom opened this issue Oct 24, 2014 · 0 comments · Fixed by #14869
Closed

glyphicon-euro incorrectly named #14867

hpoom opened this issue Oct 24, 2014 · 0 comments · Fixed by #14869
Labels

Comments

@hpoom
Copy link

hpoom commented Oct 24, 2014

Seeing as glyphicon-usd and glyphicon-gbp use the ISO 4217 standard I believe glyphicon-euro should be changed to glyphicon-eur to confirm with this standard. This would make templating from a REST API that returns ISO 4217 code a lot simpler.

My code currently is:
<span class="glyphicon {@eq key="{meta.currency}" value="EUR"}glyphicon-euro{:else}glyphicon-{meta.currency}{/eq}"></span>

It would become:
<span class="glyphicon glyphicon-{meta.currency}"></span>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants