Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are both .glyphicon-euro and .glyphicon-eur in the doc #15617

Closed
bastienmoulia opened this issue Jan 20, 2015 · 3 comments · Fixed by #15620
Closed

There are both .glyphicon-euro and .glyphicon-eur in the doc #15617

bastienmoulia opened this issue Jan 20, 2015 · 3 comments · Fixed by #15620
Labels
css docs

Comments

@bastienmoulia
Copy link
Contributor

One is glyphicon-euro, and the other glyphicon-eur.
Also the number of glyphicon is 258 instead of 260 (2 are removed).
@cvrebert
Copy link
Collaborator

Yes, we added -eur for uniformity in #14867. -euro remains for backward compatibility.
Given that we're never going to remove -euro, it's not really a problem.

@cvrebert cvrebert changed the title There is 2 glyphicon euro in the doc There are both .glyphicon-euro and .glyphicon-eur in the doc Jan 20, 2015
@juthilo
Copy link
Collaborator

juthilo commented Jan 20, 2015

IMO, both classes being in the docs is just thorough, not repetitive. And the number 260 is easier to comprehend at first glance.

@bastienmoulia
Copy link
Contributor Author

In that case, for #14867, glyphicon-ruble must also be glyphicon-rub, and glyphicon-yen must be glyphicon-jpy.
It's interesting to have it in the less, but in the documentation a phrase to inform the user of the backward compatibility is enough. No need to duplicate the glyph because that can trouble the user which will use one syntax or the other for the same things.

cvrebert added a commit that referenced this issue Jan 21, 2015
@cvrebert
Add .glyphicon-* aliases for other ISO 4217-ish currency codes
07a3ea5 
Fixes #15617.
@cvrebert cvrebert mentioned this issue Jan 21, 2015
Merged
@raghothams raghothams mentioned this issue Jun 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .glyphicon-* aliases for other ISO 4217-ish currency codes twbs/bootstrap
3 participants
@cvrebert @bastienmoulia @juthilo