Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover with trigger:"manual focus" always pops up automatically when button is clicked #16122

Closed
ghost opened this issue Mar 21, 2015 · 8 comments · Fixed by #16411
Closed

Popover with trigger:"manual focus" always pops up automatically when button is clicked #16122

ghost opened this issue Mar 21, 2015 · 8 comments · Fixed by #16411
Labels
confirmed docs
Milestone
v3.3.5

Comments

@ghost
Copy link

ghost commented Mar 21, 2015

It doesn't wait for .popover('show')
@ghost ghost changed the title Popover with trigger:"manual focus" shows automatically when button is clicked Popover with trigger:"manual focus" always pops up automatically when button is clicked Mar 21, 2015
@cvrebert cvrebert added the js label Mar 21, 2015
@cvrebert
Copy link
Collaborator

Yes, that's exactly what focus is supposed to do. Admittedly, it's not clear to me whether it's sensical to combine manual with any other triggers like you're doing here.

@ghost
Copy link
Author

ghost commented Mar 21, 2015

I want to have a popover that shows only manually, but hides when a user clicks outside.

@cvrebert
Copy link
Collaborator

You'll have to use manual and handle all the showing/hiding entirely on your own then.

@ghost ghost closed this as completed Mar 22, 2015
@cvrebert
Copy link
Collaborator

Keeping this open as, at the least, a documentation issue. And possibly we should make trigger combos involving manual throw an error.

@cvrebert cvrebert reopened this Mar 22, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Apr 4, 2015

@hnrch02 @XhmikosR Do you guys agree that combining manual with other triggers is nonsensical? Or am I missing something?

@fat
Copy link
Member

fat commented Apr 27, 2015

I agree, doesn't make a lot of sense – something to add to our option checker in v4 for sure

@fat fat added docs and removed js labels Apr 27, 2015
@mdo
Copy link
Member

mdo commented Apr 27, 2015

Should this be closed then?

cvrebert added a commit that referenced this issue May 3, 2015
@cvrebert
Document that 'manual' is mutually exclusive of other tooltip/popover…
9977864 
… triggers; fixes #16122

[skip sauce]
@cvrebert cvrebert mentioned this issue May 3, 2015
Merged
cvrebert added a commit that referenced this issue May 3, 2015
@cvrebert
Document that 'manual' is mutually exclusive of other tooltip/popover…
75d6c14 
… triggers

Closes #16122
[skip sauce]
@cvrebert cvrebert added this to the v3.3.5 milestone May 3, 2015
@rumman0786
Copy link

@ghost

I want to have a popover that shows only manually, but hides when a user clicks outside.

Were you able to implement what you wanted? I need something similar. Any snippets?

@twbs twbs locked as resolved and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed docs
Projects
None yet
Milestone
v3.3.5
Development

Successfully merging a pull request may close this issue.

Doc that 'manual' is mutex of other tooltip/popover triggers twbs/bootstrap
4 participants
@mdo @fat @cvrebert @rumman0786