Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source js files are not included in npm package for v4 #18934

Closed
s7b4 opened this issue Jan 18, 2016 · 7 comments
Closed

Source js files are not included in npm package for v4 #18934

s7b4 opened this issue Jan 18, 2016 · 7 comments

Comments

@s7b4
Copy link

s7b4 commented Jan 18, 2016

Hi,

When we install bootstrap 3.3.6 with npm, source js directory is included but no more with the v4

with both of the following commands:
npm install twbs/bootstrap#v4-dev
or
npm install bootstrap@4.0.0-alpha.2

I get this folder content

├ node_modules/bootstrap/
├── CHANGELOG.md
├── dist
├── grunt
├── Gruntfile.js
├── LICENSE
├── package.json
├── README.md
├── scss

No source js files are present.

Regards
Stéphane

@petetnt
Copy link
Contributor

petetnt commented Jan 19, 2016

There are UMD-module wrapped (and babelified / es5) files available under dist/js/umd which you can use meanwhile (if you can get the dependencies resolved, which can be a pain, I am working on improving the general modularization of Bootstrap v4: #17325 (comment))

@s7b4
Copy link
Author

s7b4 commented Jan 19, 2016

Thanks for the answer, i will try this.

@Avcajaraville
Copy link

I can't see those files. If I get bootstrap v4-dev, I'm only able to see the compiled bootrap file (minified and not minified), but no trace of umd under bootstrap/dist/js.

Im installing bootstrap through npm by having this as dependency on my package.json:
"bootstrap": "twbs/bootstrap#v4-dev"

Any help on how can I have my modules back ?

@petetnt
Copy link
Contributor

petetnt commented Jun 13, 2016

Hey @Avcajaraville,

there's a recent change (for alpha 3) on how Bootstrap will distribute its source files. See #20072 for more information.

@rosskevin
Copy link
Contributor

rosskevin commented Jul 28, 2016

I don't see es6 sources, umd, or cjs in the alpha.3 npm package. Am I missing something?

EDIT: I just noticed this milestone has been updated to alpha.4.

@cvrebert
Copy link
Collaborator

I don't see es6 sources,

That's bug #20385.

umd, or cjs in the alpha.3 npm package.

We resolved in #20072 to no longer provide pre-transpiled AMD, UMD, or CommonJS; see the PR for details.

@mdo
Copy link
Member

mdo commented Oct 19, 2016

Believe this was resolved in Alpha 4.

@mdo mdo closed this as completed Oct 19, 2016
@mdo mdo modified the milestones: v4.0.0-alpha.4, v4.0.0-alpha.5 Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants