Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #15911] Examples — Fixes navbar issues if brand is empty #15912

Closed
wants to merge 1 commit into from

Conversation

kkirsche
Copy link
Contributor

This includes the navbar fix. I did not notice any difference with the footer code so I did not include that.
Fixes #15911.

@cvrebert cvrebert added the css label Feb 25, 2015
@kkirsche kkirsche changed the title [Fixes #15911] Fixes navbar issues if brand is empty [Fixes #15911] Examples — Fixes navbar issues if brand is empty Feb 25, 2015
@cvrebert
Copy link
Collaborator

Note that :empty isn't supported by IE8, but we can probably spin this as a progressive enhancement.

@kkirsche
Copy link
Contributor Author

That's interesting, thanks for sharing that. I wonder why IE was so late when it was supported by FF 1.0 (2004) / Chrome 1.0 per MDN

@mdo
Copy link
Member

mdo commented Feb 25, 2015

Simpler fix in 05513c5.

Rather than account for weird empty states, this just makes the component more durable. The padding goes on the heading and the header gets a clearfix to ensure floats don't bust the flow.

@mdo mdo closed this Feb 25, 2015
@kkirsche
Copy link
Contributor Author

Sounds good. Thanks for that info @mdo

@kkirsche kkirsche deleted the narrowJumbotronImprovements branch February 25, 2015 00:45
@mdo
Copy link
Member

mdo commented Feb 25, 2015

@kkirsche In general, it's best to solve things like this with fewer exceptions to individual components. The presence of an element shouldn't have much of an unexpected affect on it's parent like that. It was an oversight on my part of not clearing floats properly. Hope that helps shed a bit of light on it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for the getting started "Narrow jumbotron" example layout
3 participants