Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Fix prevented show event disables modals with fade class from being displayed again #34087

Merged
merged 2 commits into from
Jul 25, 2021

Commits on May 22, 2021

  1. fix(modal): change the order we return from show() method

    In case of a modal with fading enabled, a prevented show event can cause show to not showing the modal anymore.
    
    See #34055
    alpadev committed May 22, 2021
    Configuration menu
    Copy the full SHA
    fa6c6bc View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. Configuration menu
    Copy the full SHA
    3329903 View commit details
    Browse the repository at this point in the history