Replace Sass division with multiplication and custom divide() function

[mdo]

Fixes #34353. Replaces #34386.

@XhmikosR I removed the RFS changes from that other PR for now. Want to take a stab at porting it to this branch?

• Add RFS changes in separate commit

[XhmikosR]

@mdo it seems on v4-dev we are using rfs 8.x. I'll try to see if I can cut a new 8.x release with the Dart Sass fix and then push here any patches.

That being said, I recall we still had some issues with the rounding on main. Are those sorted? If not, I'd wait until we fix everything before backporting.

[mdo]

I think everything has been sorted? We may have lost 1-2 decimals but I haven't heard any rounding bugs since we shipped the last release.

[ffoodd]

💪👌

[XhmikosR]

@mdo I created an upstream branch https://github.com/twbs/rfs/commits/v8.x. Feel free to backport the divide fix with a PR. Just keep in mind that in the upstream 8.x branch we don't test dart Sass.

[mdo]

Pulled the latest in from that branch, thanks @XhmikosR! Just rebased and force pushed. Should be good to go.

Needs RFS too

[arcanedev-maroc]

@mdo Is it ok using 0.5 instead of .5 ?

I think it's considered as a "good practice" and also we're used to see float numbers with a 0 before the dot 👀

[darrinmn9]

really sorry to nag/comment, is the only thing left on this fix to convert * .{decimal} -> * 0.{decimal} for these commits?

[mdo]

Stylistically, we don't include leading 0s in any of our CSS values, so no need to revisit those :).

[evanfuture]

Hi, just wondering if this will move ahead, it's been getting stale, and it seems like an important thing. I'll reference the above Merge request comment (from petrsiegl):

There is minor problem with scss compilation and bootstrap. V4 bootstrap uses division symbol / which is deprecated in sass and causes warnings. The fix should be available soon (#34571). Until it is merged, there will be unfortunately warnings on compilation. They can be silenced by sass --quiet flag, but that disables other warnings as well.

[ffoodd]

LGTM, what would be missing now?

[XhmikosR]

@ffoodd This is NOT ready due to RFS,please do not approve things like that because I might then accidentally merge stuff :)

[ffoodd]

Latest comments involving RFS felt accurate and up-to-date :D What's missing? Shouldn't we convert this to draft?

Not ready

[XhmikosR]

@ffoodd the backported version doesn't have the division fix. We need an upstream patch against the https://github.com/twbs/rfs/commits/v8.x branch.

[cdubz]

Just to be clear — in order to get this approved twbs/rfs#398 (essentially) needs to be backported to RFS v8.x? @ffoodd are you planning to do that work or does someone else need to jump in?

[XhmikosR]

Someone needs to do the work and provide an upstream PR, because the patch cannot be cherrypicked unfortunately.