Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update navbar color-schemes to v5.3 #37740

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Update navbar color-schemes to v5.3 #37740

merged 1 commit into from
Dec 28, 2022

Conversation

teaca-sebastian
Copy link
Contributor

@teaca-sebastian teaca-sebastian commented Dec 28, 2022 •
edited
Loading

Description

Updated the navbar/#color-schemes section to the features in v5.3

Motivation & Context

Because it was suggesting to use a feature that was deprecated in the current version of Bootstrap (navbar-dark)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #37739

@mdo mdo merged commit f9827ac into twbs:main Dec 28, 2022
@XhmikosR XhmikosR changed the title Update /#color-schemes to v5.3 Update navbar color-schemes to v5.3 Dec 28, 2022
@teaca-sebastian teaca-sebastian deleted the navbar-colorscheme-docs branch December 29, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
color mode docs v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

navbar/#color-schemes section in docs not updated properly to the 5.3 patch
3 participants
@teaca-sebastian @mdo @julien-deramond