Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS variables mentioned in our docs #37742

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Fix CSS variables mentioned in our docs #37742

merged 2 commits into from
Dec 29, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 28, 2022

Description

This PR fixes CSS Variables > Root variables > Default display of CSS vars (check https://getbootstrap.com/docs/5.3/customize/css-variables/#default) and suggests to add a new Dark mode section for these specific CSS vars.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

Related issues

Linked to #37549

@julien-deramond julien-deramond mentioned this pull request Dec 28, 2022
81 tasks
@julien-deramond julien-deramond marked this pull request as ready for review December 28, 2022 09:23
@mdo mdo merged commit baf5d4c into main Dec 29, 2022
@mdo mdo deleted the main-jd-fix-css-var-doc branch December 29, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants