Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cards color for contextual color mode #37777

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 1, 2023

Description

This PR adds a default color for .card so that it gets inherited in all .card-* classes that have corresponding $card-*-color set to null.

In order to test this modification, please double-check that the rendering is not broken:

  • in light mode in the docs
  • in dark mode in the docs
  • with contextual data-bs-theme="dark" for each card example in the docs when displayed in light mode
  • with contextual data-bs-theme="light" for each card example in the docs when displayed in dark mode

Note: I'll add a task into our tracking issue for color modes to check all the components with contextual light/dark mode as well.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #37765

@julien-deramond julien-deramond marked this pull request as ready for review January 1, 2023 22:28
@julien-deramond julien-deramond requested a review from a team as a code owner January 1, 2023 22:28
@mdo mdo merged commit 5a0899d into main Jan 2, 2023
@mdo mdo deleted the main-jd-fix-card-color-for-contextual-dark-mode branch January 2, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Text on cards don't respect data-bs-theme
2 participants