Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Doc Scrollspy correction #37898

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 17, 2023

Description

Make the doc scrollspy appear only when needed.

Motivation & Context

Every page that had no table of content (aka .Page.Params.toc = false) had its active link removed in the left sidebar, for example : Interactions, Visually hidden.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@mdo mdo merged commit e8b7d38 into twbs:main Jan 17, 2023
@louismaximepiton louismaximepiton deleted the main-lmp-doc-scrollspy-issue branch January 18, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants