Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alert-color in v5.3.0-alpha2 #38003

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

cccabinet
Copy link
Contributor

@cccabinet cccabinet commented Feb 5, 2023

Description

Change the alert text color from $themecolor-text to $themecolor-text-emphasis.

Motivation & Context

Alert text color is default text color.
Perhaps you forgot to change this when you changed $theme-colors-text from $themecolor-text to $themecolor-text-emphasis in #37907.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@cccabinet cccabinet requested a review from a team as a code owner February 5, 2023 01:41
@cccabinet cccabinet changed the title fix alert-color fix alert-color in v5.3.0-alpha2 Feb 5, 2023
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants