Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix two class attributes on same button #38317

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Docs: fix two class attributes on same button #38317

merged 2 commits into from
Mar 24, 2023

Conversation

hannahiss
Copy link
Contributor

@hannahiss hannahiss commented Mar 24, 2023 •
edited
Loading

Description

Remove redundant class attribute on button in javascript.md html code example

Motivation & Context

Remove redundant class attribute to make example correct

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@hannahiss hannahiss marked this pull request as ready for review March 24, 2023 10:46
julien-deramond
julien-deramond approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@XhmikosR XhmikosR merged commit 2008c65 into twbs:main Mar 24, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahiss @julien-deramond @XhmikosR