Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel 027 #957

Merged
merged 14 commits into from
Jun 27, 2019
Merged

Bazel 027 #957

merged 14 commits into from
Jun 27, 2019

Commits on Jun 26, 2019

  1. Change some python to python3 

    - bazel 0.27 will default to python3 in this context
- I removed the "hackish" print statement, it does not crash. I assume
  the issue is fixed.
- list > int is not valid in python3 (it was always True in python 2)
    @guibou
    guibou committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    768cdfd View commit details
    Browse the repository at this point in the history

  2. Remove deprecated cpu attribute

    @guibou
    guibou committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    62bb886 View commit details
    Browse the repository at this point in the history

  3. ghc_bindist workaround for bazel bug #8723

    @guibou
    guibou committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    2bbe9ba View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Fix ghc-paths for Bazel 0.27 

    The amount of shell indirection seems to have changed in Bazel 0.27.
Meaning that we would need twice as many `\` for the `sed` call on
Windows. The `tr` command is insensitive to single backslashes, so it's
an easier alternative.
    @aherrmann @guibou
    aherrmann authored and guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    dd38bf3 View commit details
    Browse the repository at this point in the history

  2. Bazel 0.27

    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    07ca1a4 View commit details
    Browse the repository at this point in the history

  3. Switch --incompatible_disable_genrule_cc_toolchain_dependency 

    See bazelbuild/bazel#6867
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    c7c6170 View commit details
    Browse the repository at this point in the history

  4. Switch --incompatible_no_transitive_loads 

    See bazelbuild/bazel#5636
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    0ef1ff1 View commit details
    Browse the repository at this point in the history

  5. Switch --incompatible_use_python_toolchains 

    See: bazelbuild/bazel#7899
    @guibou
    guibou committed Jun 27, 2019
    1 Configuration menu
    Copy the full SHA
    3054e52 View commit details
    Browse the repository at this point in the history

  6. Switch --incompatible_depset_is_not_iterable 

    See: bazelbuild/rules_sass#79
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    893073d View commit details
    Browse the repository at this point in the history

  7. Switch --incompatible_new_actions_api 

    See: bazelbuild/bazel#5825

Needs a protobuf update.

Note: the new protobuf needs zlib dependencies which are provided by
using protobuf_deps.
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    75eb0bd View commit details
    Browse the repository at this point in the history

  8. Switch --incompatible_no_support_tools_in_action_inputs 

    Executables must be passed as `tools` instead of `inputs`.

See: bazelbuild/bazel#5826
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    d9d5808 View commit details
    Browse the repository at this point in the history

  9. Switch --incompatible_disable_deprecated_attr_params 

    See: bazelbuild/bazel#5818
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    ec2c08c View commit details
    Browse the repository at this point in the history

  10. Switch --incompatible_depset_union 

    See: bazelbuild/rules_python#175
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    3e5acf1 View commit details
    Browse the repository at this point in the history

  11. Switch --incompatible_require_ctx_in_configure_features 

    See: bazelbuild/bazel#7793

buildifier needed an update of buildtools and rules_go, and starting from
rules_go 0.17.0, it must be loaded using go:deps.bzl.
    @guibou
    guibou committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    8d92356 View commit details
    Browse the repository at this point in the history