From dda13116c6b5f9a67ab182cd7e6ed6047a18445c Mon Sep 17 00:00:00 2001 From: Athira Sabu <102021496+AsabuHere@users.noreply.github.com> Date: Wed, 15 Mar 2023 10:09:31 +0530 Subject: [PATCH 1/4] Add step to sign nuget packages before publishing --- .github/workflows/test-and-deploy.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-and-deploy.yml b/.github/workflows/test-and-deploy.yml index ec5760b07..7405dc62b 100644 --- a/.github/workflows/test-and-deploy.yml +++ b/.github/workflows/test-and-deploy.yml @@ -82,6 +82,7 @@ jobs: - name: Publish package to NuGet run: | make release + dotnet nuget sign foo.nupkg --certificate-fingerprint 34bb5309a34488f8bac21af3169716293da2299e5ed24a07992fc557867ab809 dotnet nuget push **/*.nupkg -k ${{ secrets.NUGET_API_KEY }} -s https://api.nuget.org/v3/index.json - name: Submit metric to Datadog From 498d9b174393efcd73918550d825b4a74d8f600e Mon Sep 17 00:00:00 2001 From: Athira Sabu <102021496+AsabuHere@users.noreply.github.com> Date: Mon, 20 Mar 2023 09:56:03 +0530 Subject: [PATCH 2/4] Modifying workflow to sign nuget packages before upload --- .github/workflows/test-and-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-and-deploy.yml b/.github/workflows/test-and-deploy.yml index 7405dc62b..0585db720 100644 --- a/.github/workflows/test-and-deploy.yml +++ b/.github/workflows/test-and-deploy.yml @@ -82,7 +82,7 @@ jobs: - name: Publish package to NuGet run: | make release - dotnet nuget sign foo.nupkg --certificate-fingerprint 34bb5309a34488f8bac21af3169716293da2299e5ed24a07992fc557867ab809 + dotnet nuget sign **/*.nupkg --certificate-path .github/nuget/TwilioCLISigningCertificate.pfx --certificate-password ${{ secrets.NUGET_SIGNING_KEY }} dotnet nuget push **/*.nupkg -k ${{ secrets.NUGET_API_KEY }} -s https://api.nuget.org/v3/index.json - name: Submit metric to Datadog From 4834386606bd679c4ef43d69833f8c84123f295b Mon Sep 17 00:00:00 2001 From: AsabuHere Date: Mon, 20 Mar 2023 09:58:54 +0530 Subject: [PATCH 3/4] Adding certificate for nuget signing --- .github/nuget/TwilioCLISigningCertificate.pfx | Bin 0 -> 6413 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 .github/nuget/TwilioCLISigningCertificate.pfx diff --git a/.github/nuget/TwilioCLISigningCertificate.pfx b/.github/nuget/TwilioCLISigningCertificate.pfx new file mode 100644 index 0000000000000000000000000000000000000000..4a74c07e2cf025c5ff43a6a9b92e7c500847ec68 GIT binary patch literal 6413 zcmY+HWmFV^)~;cIp?i?d0YpMt>6R3v8|fH22Wc2Or5i-LL68pV?k>rpyBj{wTHn3r z-XDAIwVrqF{ri15V5H~(L?jLv$v6<5IYc((78?;2F$YG{fea&Q{f8SlU^u(~jet2Y zoP~dA27rk0Z;k#pLFAwSV*Kw1EJPp&4l>$ItfPBP94{0AKtu3{;p9A2V#AXPp$Y>_ zEVY)VU}7Q0Kxm`hm{2$}WoQHCl04EYZef_Z>ka6G7(TS*LHZRb3V=KBk8ITVs}7KCk`iS1nRVU69O^S00}!?Yc&ONcqP# z#2sehbf?)jVu8u#m6`Pp3>{8_%7!F2AM~@-s>S4}H+2UVEz12>qXKdtN4b3na@%oI zTmr@^e~kQ+zn@}m3jC<*jLf9g>ufGORT<@DEgG#EX=*CHGxqH1;XBkmM>JA4wvl~r zvmoyt|Em%F~8Rbw_$AHAmRi>!v4wSlF0bS1F836T`iFAWJxo&1iAa0#fBXlRaoL-8>PNyLE zh_<^ELpl;v`cMTayVR%&Ig{=?#a;QHVMgYp-;`rEiSxr>7A9Q1{{2T;p+nVP*f~Xu64D@ z#|w4fsi>xcQKV?hv5xuw4h@p19t$R?;@w>7=|7BR!A*FvOS6DdP}Sc^7ux~}v!+;a zvaWlxEpk#G75SUi_z>b47>Faeihq&HMwBw&ZhCG0jir3j|Ke97MJESeHdsdV9KW*m zcRs~6(EZNiVIK^#tukNW(q_wT;2uV$`oPbRo-H(H24(risA660SK?y*l3<(y@l%C; zjJ&-6wI=n;JILE1qTmDpk^1R^TCn^SY>$Ti1E%-u0V& ziAJuFMhT^JGOG&|hb~b44sMf#19~&WoRU6t!O|V&+5^boaav)KH#{l*{h&6mzr+vU zc40nbnt}p%#MP9c<;M)3hUU*d>0(5>AtDbHGh;9XKV;W@VNil}XCLg%=nVp2ADZ?v z(M{}6y^qj!{9uORGJTLsVFFxKtK=6TDTH;vF76|xAzX(hu!95HA@Ye4-9hLhz`Zio zZHCux@{$5*76Sup4vhi(@Wh-iPJJ7r{!n*D-lA>1M_=AaAZ*A%z(sTmrx=A8Q+v}_ zvm1M7R+daXjVODDv&yb(*qWJ_mH8*9@pA4xMars&a`MO@h=I40J9e|NB=!w;n!?PDL>C#2d{xK~ z&&G7Y6lK|L@Kd7t*JAe+y8KCH9yr3xH*xgk9O65s83Uh*-;%4m@tb43L|lWEuOx5I z8MTdELV8Z55)4z8Qx#8rJ0FOQqVs%WV>`+u&B){9rd*bS-piHRGVA|T2?ZaCWtn{i z8J}Q(*ySmFZUSBZzOTSzxc~F&lxQ^E5fKM8Gb46zaphSQZtTvDKXF9LDvT2Rooe!{ z#}9`&mJWYW$9vR^YF{s(D3;4*QfmxWidFK+w`+oZh%Cs_`;V?%o!*%6FXc6H18AkP}Fy5KoHQmrsgySfu%uTkIq{K-B^gx1azRD>v z(pft$O#xWetD-)f0VrK9)sW}vD#Xiw^`UR1-D%Qr8@r7(eFzNK`ab~P>iig&NA>3zp(INDuTvGDQFx$4Lht@oGj z$?U;lGaOkJgB-iped4R~1jANdpNdLEWX5|6NGXSJ&%7c^`LcF3^oMo+>XDeH`gKP$ z0MDoy+ra7t8b8csi3So!gl9WHP|R2-Gc^uchM{!aXsgL=rLy29I;sr!R{;vSS&SlA z;lgq4IY%4nm#)E!#t_c2amwx*1)LST;mQbs03v4#_uWF?81n%Z9lI5?1UHJR>F5MK zuyaoKr%v50itNB*Q)&1(MmBjj-D1}1=1Aagp(U)f`X*~>gF~|MSq-YuXUXYhoQ01p z*LjlLL31g&;su9D?E@N;uDXo-)asWo#Lj-r#&;shP6l(o35517q8``wHXA8}CEjOf zoE<4y5tb7BNPcMEtvz0gRV6G^U@N(%Tbi{G3ECQ}C3F;`sqTIP_b)jS<+l5_*!|>b zhWOpPoMuhZtK+cow9~JJ!eC&PIi*%%RzJEo3YmbkXCh?VK+_uS?t+yqHtKWH^b_&P zgZekheqL0}Cw^mdUsd8gM2dRJs*(Dt&U3>EtJJDUR!HP%b;JE{unSZv!);~GzOv#% zD93H?>5kjz<-TjTY2_C8IV}{&s{F7V-cgUrRA)P)Q#tj?KYtNT=6T`N$zCmcubx?L zipGiLs=5?WcBEYZ|7?AE)kkv72SBQr$*Y|osSfa^i!(j$y))oQqD(lxnXe z(*)&jPIuHyrJj4);N7B!$yc|=ADG2auF9-377iv^oa9M9Rz7-O5;CsOGinA`6S*a= zowMD7ri>19VU>fLiA0Ehe4>r_nVht`e}raxJ(vxB_G7!y>E_hcp`3$l_rIv+e#e{u zl?4gbu<7}M>T`5Fuz+q?;nuU>rT!jG!frg-$aeCi&*Q`XuoXEm#~J^Vda(Q}C< z%%2Y7{TKNhG*7zJm>y?qcHib|3O9JTAnPv?w+7m&8{V`Y0UIZW{e2A0Xlo0H=^*6Q zG3pA)ZNc2Qf!`h&Nk5!1Ye{Tj7MV>>fLIR4Cg}x~zNE>K*uyAku%SU(F%gjN}I2+E3U%|nN!$IE7 zoI)2%Zd+Ed{{>LCvAm+xud@32E%`Hr%nHP}maRPhU6&d29^%0qud8wld}kRYeyb?E zv%%(F4fFc-uYfm0PCcq)*Ue`Q*a)S3g4_Eu%;K=RI{+$hdN<<$s8`kK5j6>EA3wpe z{w}7+EZY8S6qm4oSLh>yzshV(k^$>QT(l80B-HLSY$`GH+Y~8#5h}<4k6)M zq+UxKbo1@{8D;TpM-}_&pP5j}q7qw!oW~>3q3p$PPKj&ujIcQo)^ux}4|5sH&J|gy zVNn^M(-1I~z)IdX2XV_Y)6Q%>(5yyoJ!ffgpIFLMT=bZU7Q=E&l9oPu^xZYSM?-pIXahQbPJBRN2@2m4iaG+&I)$Y{E z_8@ulI*@*RNVpE;i&ibE!N6PUj|`M)znz~DOp%C{Iu7W7llPe$_w3;D9pZ+063eQ-$fJBiaW=fyP_j=FZaf?Ne5IYH1U zr}7R|$#^cs=+4FyT^|1w5LQ5uOIhn<)exK z^45JjQKZ4&8=t}vH;~h9G*XI52#7@nVoIDspweAB3uu)4tUwu$qAj-8M6k46dGkmR zq}Nm2CG&Y`fXEK>2rFsDnNnYG(S~R3E1{h9qIP6waeU#Kd}kMx&O|UB)3ASrylsP_ zkT&|YG?oX}!=5geN7>PtCgll^px9RD3O}j0Wnmfj#FX&{xYk4-xe$puN|I>H&jHBA z=vHZss<56G7)?IxY4Ta;@O=uZW^1~tB@{d=mS=t)O zT{AQUoKddOKZCla&jFWhs41FAU|R>3eWI%HUP1gW)Fv-Q7mZ?yVmD7UocT8Ps4~>* zLu+&Ea0+E+mRDg?H9bd8x=Mn?6rxxdD<-DJCUKu+9l{Yez1Q(es&N|htC@WzZJeYw zj&HmFO!>k0T!z<8i@z*Kac>jVn2h3|xYy##osv#-T;@rX2=WXb6ySx11` zVe{LD1O}7%65E>1J-?=PyX>h!ua3_mvf#NMD5$|6|D_R0{>gNRBUYR+tXLTHeFVVA z{=mKbEQH#&(&^=ISlind8!D|IP`7Lj)9tIoMLsP`_BtmUkE^9KPbqT_2C$v~Y{Ek`Kuwjsx-6 zBHSwFFck(#NewSHL#VLKa(ab>Y$`qoFI47K}e z_*jQ|;gEXHaM7es3&As%ROEp^uMZG`GDp3=Au<97&yeE7svbM-RK-cji|v8>{M>bF zU0cKq`Rar<>5ld%#T2^6Z?v_ERyA1KPdHp48_Sgxqy+>Btz}2#rZlWW?FG7qT@R-` zb`f}eGp-inrDsy5>*bt{P+c`sT#RDl>21I1rZbV>OxK5JLOps5N78fPac1JQS`JrC zyIZ^xweOyy2<~R3j49E_*td_)Q^J}}3GJ)}_Pcw#*;QyrE+12}A9CdE?msl_IY?-# zj6!%`7)psB%6J$y`~bCCbg18|-9q z+!F7u>N7UEWwCsena%uNQH;2;IsMkof)alz#LM&w>Qp!T;>MtR*g+uUEMg<(*chfY za{iNY9V2G3_gH~hY~a}`^lY1Z!k{PTyEx|-kp>HFeu}8BJ_?_MxBQcOCHCf`BfCUw z=U&BW^J&X1hbLrp5AZfUQMqGdMClVzM{>TDl5mNU$T5>RS#>>x->WN-qB(;{-~AJH z=TZL``Fu;lL=f3@N4GwQK!EOoA%;dSSVp5oZ!hC#DDN3OW5{nxwi1KZPYB`Jut&p2 z^ZF9aC{i*!+5Z7hR}vmRzo@C@`Bwk2&iKIa_^{zl!cDCel}?Kc&FGSijLgSjBUUI` z)b|7h`lGVl8uIXHE=8kw`?YrDe4=6_ZY01i7cHd5&pfWm!O*}PC6jnL;y6H*fOvn% zcC=R)Cssi$)q=8f_}bl@4GExT%SG&jQ4Rl05N056cTy#g0`yvbeYv=hP=EWeQ{UwQ z^@+x|7d^PE4_9|pbY$FEZ6~D`b6{Fo@S>$;%@i+4SoPt$WxQJfQ)+LVJ0CdJ&75SK zzOt4SX)`0y2Vm~W(JEr#2ueuspiBAzuXq{B_@qpSb`h!6vPccRQP>h$!DwL!=4_aCuVl`&MhCce|bXnqqbzMH>G)b*@8J*z>@Ob*(t zOwsWZPaHPy16$~*hFs4gmKqj%OPv6uuj2U>P2+M zcy{6Ju55iC{HTfhHUH%13I&E4Ej-*ZHF#SbE4rqYM;RGQ@&}ZDv)zZ~29q@|kA{3D z$pP6F$jI^!8zilRtcRL0Jw9?LyfrJ?EDPeO15Mu%=b48!U%dZ7Z-l_-DeWbq6HZW6 zk~4xf`6;fQRq8fWp+=)(A2Xqmh+}vKxEE?&nUv(#GAdjpD4@d04ltM-t^r#!>}2FS zfS>!~TrRLIy<(_uLttsLp9)@;J?dBvrJjs*-shx91{m&|S;MU8?Fu#03j!<|Rf+RN zGE>&j)cJ3rcmr4uS_{tTEs@%VG3ksXC~l?j^QW%vclx{x>2LTALFLr*f;{zpw2dB1 zi&>aCWz^)`(s$gC0x~4>9x`M4R1MB{2SfvwOTwtlWP5juH*%u5{Ka@^A6l4P9N`}Ap Vzvaz9Mk6(a-b6@%!~fIP{s+=|K2!hz literal 0 HcmV?d00001 From 05cafb9f65df6964b7b9f1d9941df023bf863f30 Mon Sep 17 00:00:00 2001 From: Athira Sabu <102021496+AsabuHere@users.noreply.github.com> Date: Tue, 21 Mar 2023 17:27:51 +0530 Subject: [PATCH 4/4] Changing the name of secret holding certificate password for code signing --- .github/workflows/test-and-deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-and-deploy.yml b/.github/workflows/test-and-deploy.yml index 0585db720..142e15cc7 100644 --- a/.github/workflows/test-and-deploy.yml +++ b/.github/workflows/test-and-deploy.yml @@ -82,7 +82,7 @@ jobs: - name: Publish package to NuGet run: | make release - dotnet nuget sign **/*.nupkg --certificate-path .github/nuget/TwilioCLISigningCertificate.pfx --certificate-password ${{ secrets.NUGET_SIGNING_KEY }} + dotnet nuget sign **/*.nupkg --certificate-path .github/nuget/TwilioCLISigningCertificate.pfx --certificate-password ${{ secrets.CERTIFICATE_PASSWORD }} dotnet nuget push **/*.nupkg -k ${{ secrets.NUGET_API_KEY }} -s https://api.nuget.org/v3/index.json - name: Submit metric to Datadog