Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setting contentType correctly in java #608

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Sep 3, 2024

Fixes

Setting contenttype in java based on consumes property and "mediaType"

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 changed the title chore: setting contenttype in java based on bodyParams chore: setting contentType correctly in java Sep 5, 2024
Copy link

sonarqubecloud bot commented Sep 5, 2024

Copy link

sonarqubecloud bot commented Sep 5, 2024

Copy link

sonarqubecloud bot commented Sep 5, 2024

Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tiwarishubham635
Copy link
Contributor Author

PR in twilio-java showing these changes twilio/twilio-java#812

@sbansla sbansla merged commit e2245e0 into main Sep 5, 2024
16 of 20 checks passed
@sbansla sbansla deleted the fix_content_type_java branch September 5, 2024 10:02
AsabuHere pushed a commit that referenced this pull request Sep 20, 2024
AsabuHere pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants