Misc catchup #38
Merged
Misc catchup #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code changes look fine, hope you tested building ;) |
|
I've been testing the individual commits so the feature itself should definitely work. Nothing else seemed broken either but I didn't do any kind of thorough testing of the other parts of the app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided it would probably be better to just group a bunch of small commits into one PR since it would be annoying to pull each one in separately. The next PRs should be on bigger features like VOD chat replay.
dab8ab1 might fix issue #6 as I experienced that bug with the ampersand character but not with spaces.