Drop compat cruft

[hynek]

So this removes all the obvious, machine-removable pre-3.7 compat cruft. There's some OrderedDicts that could be replace by normal ones, but that's a bit more delicate because insert order is preserved, but not on creation.

---

The version in docs/conf.py should probably not be hard-coded? But I'm not sure how docs are built since https://towncrier.readthedocs.io/ has only latest.

---

To ensure modern code, I've added a pre-commit tox env and a very simple pre-commit config. If you're OK with that, I would also add flake8, black, and isort to it and talk to Anthony to get us free per-commit.ci (much faster than GHA, fixes problems in-PR)..

[codecov]

Codecov Report

Merging #380 (425325f) into master (aead491) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   97.00%   97.60%   +0.59%     
==========================================
  Files          22       22              
  Lines        1337     1334       -3     
  Branches      250      253       +3     
==========================================
+ Hits         1297     1302       +5     
+ Misses         20       16       -4     
+ Partials       20       16       -4     

Impacted Files	Coverage Δ
src/towncrier/_settings/fragment_types.py	100.00% <ø> (ø)
src/towncrier/build.py	96.42% <ø> (-0.05%)	⬇️
src/towncrier/test/test_settings.py	100.00% <ø> (ø)
src/towncrier/_builder.py	100.00% <100.00%> (+5.88%)	⬆️
src/towncrier/_project.py	71.05% <100.00%> (-0.75%)	⬇️
src/towncrier/_settings/load.py	95.77% <100.00%> (-0.06%)	⬇️
src/towncrier/_writer.py	86.95% <100.00%> (-1.05%)	⬇️
src/towncrier/check.py	94.11% <100.00%> (-0.12%)	⬇️
src/towncrier/create.py	97.72% <100.00%> (-0.06%)	⬇️
src/towncrier/test/test_build.py	100.00% <100.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aead491...425325f. Read the comment docs.

[hynek]

I'm confident the global coverage changes are again due to removal of lines.

I think it would be a good idea to switch off the global check (and keep the patch check) until towncrier has 100% code coverage. Otherwise there's gonna be a lot of red/failed PRs which is somewhat demoralizing.

[adiroiban]

The code coverage reports are only "informational" they are not blocking a PR.

---

The RTD build is brand new. This is why it only has latest.
There was no version release with support for RTD. This is why it only has latest.

I agree that the version should not be hardcoded. PR welcomed :)

---

I know some people would like to see py2.7 and python 3.5 support in Towncrier.

But as mentioned, I am only the maintenance maintainer:)

So I will approve it.

The reasoning is that in 10 years we might want to do these changes anyway.
And since we have the resources to the them now, let's do it.

Many thanks for the PR.

[adiroiban]

For a glorious py3 future.

[adiroiban]

@hynek it looks like this is a missing code coverage.

I expect that this is very easy to cover, by updating the format used by an existing test.

[hynek]

Could it be that there was a subtle bug or something working by accident before? 🤔

[adiroiban]

Nope. Just missing test.

Here is an example of an updated test that will provide full cover for this feature

diff --git a/src/towncrier/test/test_build.py b/src/towncrier/test/test_build.py
index 66a1123..671f2e2 100644
--- a/src/towncrier/test/test_build.py
+++ b/src/towncrier/test/test_build.py
@@ -622,6 +622,9 @@ class TestCli(TestCase):
     def test_bullet_points_false(self):
         """
         When all_bullets is false, subsequent lines are not indented.
+
+        The automatic ticket number inserted by towcier will allign with the
+        manual bullet.
         """
         runner = CliRunner()
 
@@ -634,7 +637,24 @@ class TestCli(TestCase):
                 )
             os.mkdir("newsfragments")
             with open("newsfragments/123.feature", "w") as f:
-                f.write("wow!\n~~~~\n\nAdds levitation.")
+                f.write(
+                    "wow!\n"
+                    "~~~~\n"
+                    "\n"
+                    "No indentation at all."
+                    )
+            with open("newsfragments/124.bugfix", "w") as f:
+                f.write(
+                    "#. Numbered bullet list."
+                    )
+            with open("newsfragments/125.removal", "w") as f:
+                f.write(
+                    "- Hyphen based bullet list."
+                    )
+            with open("newsfragments/126.doc", "w") as f:
+                f.write(
+                    "* Asterisk based bullet list."
+                    )
 
             result = runner.invoke(
                 _main,
@@ -666,8 +686,29 @@ class TestCli(TestCase):
             wow!
             ~~~~
 
-            Adds levitation.
+            No indentation at all.
             (#123)
+
+
+            Bugfixes
+            --------
+
+            #. Numbered bullet list.
+               (#124)
+
+
+            Improved Documentation
+            ----------------------
+
+            * Asterisk based bullet list.
+              (#126)
+
+
+            Deprecations and Removals
+            -------------------------
+
+            - Hyphen based bullet list.
+              (#125)
             """
             ).lstrip(),
         )

[hynek]

But how come we seem to have lost it now? I'm just on my phone ATM so I can't check but the old mixture of u and non-u strings looks sketchy? 🤔

[hynek]

I know some people would like to see py2.7 and python 3.5 support in Towncrier.

We should keep in mind that:

• towncrier is a tool, so the version it runs on is rather circumstantial. Especially given it’s a tool you nominally only need while releasing software.
• There’s plenty of towncrier releases for those versions. :)

[adiroiban]

The code coverage reports are only "informational" they are not blocking a PR.

I mean the overall "project" report is optional.

I think that the patch coverage should be required 100% as the minimum level to ensure a glorious future.

[adiroiban]

@hynek I have enabled auto-merge for this PR.
Can you try to apply the updated test from the path .
I hope that with that we can get 100% coverage and this will be automatically merged.

[hynek]

@hynek I have enabled auto-merge for this PR.

Can you try to apply the updated test from the path .

I hope that with that we can get 100% coverage and this will be automatically merged.

Sure, but I'm not positive I can get to a computer until tomorrow.

If you want to speed things up, you could try to "suggest" the change in PR so I can just accept it? 🤔 It should be alt-g IIRC.