diff --git a/CHANGELOG.rst b/CHANGELOG.rst index c2c18be9f2..2984c0e91f 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -7,6 +7,14 @@ Note that ``RB_ID=#`` and ``PHAB_ID=#`` correspond to associated message in comm Unreleased ---------- +Changed +~~~~~~~ + +* inject-thrift-client: Deprecate `c.t.inject.thrift.AndThenService`, `c.t.inject.thrift.modules.AndThenServiceModule`, + and `c.t.inject.thrift.internal.DefaultAndThenServiceImpl`. These were plumbing for unreleased + experimental record/replay functionality and currently do nothing with no plan for implementation. + ``PHAB_ID=D845841`` + 22.2.0 ------ diff --git a/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/AndThenService.scala b/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/AndThenService.scala index 673a56b3b8..9cff9b3f39 100644 --- a/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/AndThenService.scala +++ b/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/AndThenService.scala @@ -1,8 +1,11 @@ package com.twitter.inject.thrift -import com.twitter.finagle.{Filter, Service} -import com.twitter.scrooge.{ThriftMethod, ThriftStruct} +import com.twitter.finagle.Filter +import com.twitter.finagle.Service +import com.twitter.scrooge.ThriftMethod +import com.twitter.scrooge.ThriftStruct +@deprecated("No replacement.", "2022-03-03") trait AndThenService { def andThen[Req <: ThriftStruct, Rep]( method: ThriftMethod, diff --git a/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/internal/DefaultAndThenServiceImpl.scala b/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/internal/DefaultAndThenServiceImpl.scala index 171ee87c7a..4063d55af2 100644 --- a/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/internal/DefaultAndThenServiceImpl.scala +++ b/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/internal/DefaultAndThenServiceImpl.scala @@ -1,9 +1,12 @@ package com.twitter.inject.thrift.internal -import com.twitter.finagle.{Filter, Service} +import com.twitter.finagle.Filter +import com.twitter.finagle.Service import com.twitter.inject.thrift.AndThenService -import com.twitter.scrooge.{ThriftMethod, ThriftStruct} +import com.twitter.scrooge.ThriftMethod +import com.twitter.scrooge.ThriftStruct +@deprecated("No replacement.", "2022-03-03") private[thrift] class DefaultAndThenServiceImpl extends AndThenService { def andThen[Req <: ThriftStruct, Rep]( method: ThriftMethod, diff --git a/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/modules/AndThenServiceModule.scala b/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/modules/AndThenServiceModule.scala index de0dfe9a37..2e47d43482 100644 --- a/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/modules/AndThenServiceModule.scala +++ b/inject/inject-thrift-client/src/main/scala/com/twitter/inject/thrift/modules/AndThenServiceModule.scala @@ -4,9 +4,10 @@ import com.twitter.inject.TwitterModule import com.twitter.inject.thrift.AndThenService import com.twitter.inject.thrift.internal.DefaultAndThenServiceImpl +@deprecated("No replacement.", "2022-03-03") object AndThenServiceModule extends TwitterModule { - override def configure: Unit = { + override def configure(): Unit = { bind[AndThenService].to[DefaultAndThenServiceImpl] }