Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller lzo indexes: make #43 apply to current codebase #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dvryaboy
Copy link
Contributor

@dvryaboy dvryaboy commented Sep 5, 2014

Make smaller lzo indexes by encoding the offsets instead of just writing them down naively.

Note this does not address any of @rangadi's comments from 2 years ago on #43, this is just bringing the PR up to a point where it can be applied to the mavenized build.

@dvryaboy
Copy link
Contributor Author

dvryaboy commented Sep 5, 2014

ugh MacOS is fighting git on file capitalization.. one sec.

@dvryaboy
Copy link
Contributor Author

dvryaboy commented Sep 5, 2014

Ok the test failures appear unrelated:

SEVERE: Could not load native gpl library

java.lang.UnsatisfiedLinkError: no gplcompression in java.library.path

The new tests actually pass.

</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why your build failed. The maven antrun plugin is required for building the native binaries, and since the plugin was removed the native binaries were not generated, thus the errors.

Curious, is it necessary to make this change? If so, why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary at all, I think that was me trying to get the build to
pass....

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dmitriy Ryaboy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants