From 4d33e00bc947981a8b53f43a56a3ff8847bfaa02 Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 12:28:04 -0400 Subject: [PATCH 01/10] Disable ci_test workflow --- .github/workflows/ci_test.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci_test.yml b/.github/workflows/ci_test.yml index b23ae7109..a12789096 100644 --- a/.github/workflows/ci_test.yml +++ b/.github/workflows/ci_test.yml @@ -4,19 +4,19 @@ name: ๐Ÿ›๐Ÿ“ฆ Build & Test on: workflow_dispatch: - push: - branches: - - master - - develop - - 'v[0-9]+.[0-9]+.[0-9]+' # release branches have the form v1.9.x - - 'rc[0-9]+.[0-9]+.[0-9]+' # release candidate branches - - pull_request: - branches: - - master - - develop - - 'v[0-9]+.[0-9]+.[0-9]+' # release branches have the form v1.9.x - - 'rc[0-9]+.[0-9]+.[0-9]+' # release candidate branches + # push: + # branches: + # - master + # - develop + # - 'v[0-9]+.[0-9]+.[0-9]+' # release branches have the form v1.9.x + # - 'rc[0-9]+.[0-9]+.[0-9]+' # release candidate branches + + # pull_request: + # branches: + # - master + # - develop + # - 'v[0-9]+.[0-9]+.[0-9]+' # release branches have the form v1.9.x + # - 'rc[0-9]+.[0-9]+.[0-9]+' # release candidate branches env: From ddcafe91c8494418d8f1e49ca1b6d578074d54b2 Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 13:39:53 -0400 Subject: [PATCH 02/10] Add linting job --- .github/workflows/ci.yml | 41 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 000000000..473142d9b --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,41 @@ +--- +name: ๐Ÿ›๐Ÿ“ฆ Build & Test + +on: + workflow_dispatch: + + push: + + pull_request: + branches: + - master + +jobs: + code-linting: + name: ๐Ÿ“ก Code Linting + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Python + uses: actions/setup-python@v4 + with: + python-version: 3.8 + + - name: Install Armory + run: pip3 install --no-compile --editable '.[developer]' + + - name: Install pre-commit + run: pip3 install pre-commit + + - name: Lint + run: make lint + +# static-analysis: + +# unit-tests: + +# generate-docs: + +# build: From b7aacf5d09d1d25260600cf7d3f0495b53de9da0 Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 13:50:44 -0400 Subject: [PATCH 03/10] Add other CI jobs --- .github/workflows/ci.yml | 85 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 78 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 473142d9b..b91608afb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,19 +23,90 @@ jobs: with: python-version: 3.8 - - name: Install Armory - run: pip3 install --no-compile --editable '.[developer]' - - name: Install pre-commit run: pip3 install pre-commit - name: Lint run: make lint -# static-analysis: -# unit-tests: + static-analysis: + name: ๐Ÿšง Static Analysis + runs-on: ubuntu-latest + needs: code-linting + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Python + uses: actions/setup-python@v4 + with: + python-version: 3.8 + + - name: Install tools + run: pip3 install bandit mypy + + - name: Scan + run: make scan + + + unit-tests: + name: ๐Ÿงช Unit Tests + runs-on: ubuntu-latest + needs: code-linting + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Python + uses: actions/setup-python@v4 + with: + python-version: 3.8 + + - name: Install + run: make install + + - name: Test + run: make test + + generate-docs: + name: ๐Ÿ“– Generate Docs + runs-on: ubuntu-latest + needs: + - code-linting + - unit-tests + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Python + uses: actions/setup-python@v4 + with: + python-version: 3.8 + + - name: Install tools + run: pip install mkdocs mkdocstrings mkdocs-exclude mkdocs-material + + - name: Generate + run: make docs + + build: + name: ๐Ÿ”จ Build + runs-on: ubuntu-latest + needs: + - code-linting + - unit-tests + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Python + uses: actions/setup-python@v4 + with: + python-version: 3.8 -# generate-docs: + - name: Install + run: make install -# build: + - name: Build + run: make build From d08ef574f8356080812dd0dcd6bc1d694941dd9c Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 14:02:54 -0400 Subject: [PATCH 04/10] Fix library name in pyproject --- pyproject.toml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 4ba566a7b..e30a77128 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -105,9 +105,9 @@ extras = [ ] all = [ - "charmory[developer]", - "charmory[documentation]", - # "charmory[extras]", + "armory-library[developer]", + "armory-library[documentation]", + # "armory-library[extras]", ] From 425a3d24188949212db4a3f9087be14476ad5a33 Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 14:31:43 -0400 Subject: [PATCH 05/10] Upload artifacts --- .github/workflows/ci.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b91608afb..db2b4f666 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -49,6 +49,13 @@ jobs: - name: Scan run: make scan + - name: Upload Scan Results + uses: actions/upload-artifact@v3 + with: + name: bandit + path: bandit_scan.txt + retention-days: 1 + unit-tests: name: ๐Ÿงช Unit Tests @@ -69,6 +76,7 @@ jobs: - name: Test run: make test + generate-docs: name: ๐Ÿ“– Generate Docs runs-on: ubuntu-latest @@ -90,6 +98,14 @@ jobs: - name: Generate run: make docs + - name: Upload Docs + uses: actions/upload-artifact@v3 + with: + name: docs + path: public + retention-days: 1 + + build: name: ๐Ÿ”จ Build runs-on: ubuntu-latest @@ -110,3 +126,10 @@ jobs: - name: Build run: make build + + - name: Upload Wheel + uses: actions/upload-artifact@v3 + with: + name: wheel + path: dist/*.whl + retention-days: 7 From 53956f8f0b36ca3b453d22fa9de7e19a8b6a4317 Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 14:48:40 -0400 Subject: [PATCH 06/10] Rename uploaded artifacts --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db2b4f666..5803f6367 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -52,7 +52,7 @@ jobs: - name: Upload Scan Results uses: actions/upload-artifact@v3 with: - name: bandit + name: bandit_scan.txt path: bandit_scan.txt retention-days: 1 @@ -101,7 +101,7 @@ jobs: - name: Upload Docs uses: actions/upload-artifact@v3 with: - name: docs + name: armory-library-docs path: public retention-days: 1 @@ -130,6 +130,6 @@ jobs: - name: Upload Wheel uses: actions/upload-artifact@v3 with: - name: wheel + name: armory-library-wheel path: dist/*.whl retention-days: 7 From 3d2439f9a6872d7e28efb4b4603d1c95bb8e9447 Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 15:05:28 -0400 Subject: [PATCH 07/10] Rename bandit artifact --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5803f6367..0204db035 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -52,7 +52,7 @@ jobs: - name: Upload Scan Results uses: actions/upload-artifact@v3 with: - name: bandit_scan.txt + name: armory-library-bandit path: bandit_scan.txt retention-days: 1 From 8f6a790ff8fec41a033222792bd653e7e0c2f50c Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 15:21:40 -0400 Subject: [PATCH 08/10] Remove unneeded github-actions workflow files --- .github/workflows/1-scan-lint-build.yml | 117 ----------------------- .github/workflows/2-test-stand-alone.yml | 70 -------------- .github/workflows/3-test-docker.yml | 93 ------------------ .github/workflows/ci_test.yml | 35 ------- .github/workflows/scenario-runner.yml | 92 ------------------ .github/workflows/self-hosted.yml | 71 -------------- 6 files changed, 478 deletions(-) delete mode 100755 .github/workflows/1-scan-lint-build.yml delete mode 100755 .github/workflows/2-test-stand-alone.yml delete mode 100755 .github/workflows/3-test-docker.yml delete mode 100644 .github/workflows/ci_test.yml delete mode 100644 .github/workflows/scenario-runner.yml delete mode 100644 .github/workflows/self-hosted.yml diff --git a/.github/workflows/1-scan-lint-build.yml b/.github/workflows/1-scan-lint-build.yml deleted file mode 100755 index 268a77eb8..000000000 --- a/.github/workflows/1-scan-lint-build.yml +++ /dev/null @@ -1,117 +0,0 @@ ---- -name: ๐Ÿ™ˆ ๐Ÿ™‰ ๐Ÿ™Š Scan & Lint - -on: workflow_call - -jobs: - code-quality: - name: ๐Ÿฆ„ Code Quality - timeout-minutes: 10 - runs-on: ubuntu-latest - steps: - - name: ๐Ÿ„ Got git? - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - # Get history and tags for SCM versioning to work - - name: ๐Ÿ“ฉ Checkout the Source - run: | - git fetch --prune --unshallow || true - git fetch --depth=1 origin +refs/tags/*:refs/tags/* - # Verify .git folder - if [ ! -d "./.git" ]; then - echo "Expected ./.git folder to exist" - exit 1 - fi - - - - name: ๐Ÿ Switch Python 3.9 - uses: actions/setup-python@v4 - with: - python-version: 3.9 - - - - name: ๐ŸŒฑ Setup Test Enviroment - run: | - python3 -m pip install --upgrade pip - python3 -m pip install --upgrade build - - export ARMORY_ROOT_DIR=`git rev-parse --show-toplevel` - export ARMORY_SRC_DIR="${ARMORY_ROOT_DIR}/armory" - - mkdir -p /tmp/artifacts - - - - name: โš™๏ธ Installing Armory - shell: bash - run: | - pip3 install --no-compile --editable '.[developer]' - - armory configure --use-defaults - - echo `armory --version` > /tmp/artifacts/version.txt - - - - name: ๐Ÿš€ Run commit hooks - env: - ARMORY_COMMIT_HOOK_CI: 1 - run: | - echo "๐Ÿ’„ Running commit hooks for Armory version ${VERSION}" - bash tools/pre-commit.sh - - - - name: ๐Ÿ“ฆ Build Testing - run: | - python -m \ - build \ - --sdist \ - --wheel \ - --outdir dist/ \ - . - - pip3 install --no-compile dist/*.whl - - armory configure --use-defaults - - if [ $? -ne 0 ]; then - echo "๐Ÿšจ Build failed. Please fix the issues ๐Ÿš‘" - exit 1 - fi - - - - name: ๐Ÿฆนโ€โ™‚๏ธ Scanning with Bandit - run: | - bandit \ - -v \ - -f txt \ - -r ./armory \ - -c "pyproject.toml" \ - --output /tmp/artifacts/bandit_scan.txt \ - || $( exit 0 ); echo $? - - - - name: ๐Ÿ–‹๏ธ mypy Type Checking - run: | - python3 -m pip install mypy - python3 -m pip install types-requests - mypy \ - armory \ - --ignore-missing-imports \ - --follow-imports=skip \ - --show-error-codes \ - --show-column-numbers \ - --pretty \ - > /tmp/artifacts/mypy.txt \ - || $( exit 0 ); echo $? - - - - name: ๐Ÿ“ Archiving Artifacts - uses: actions/upload-artifact@v3 - if: ${{ !failure() }} - continue-on-error: true - with: - name: scan-artifacts - retention-days: 1 - path: | - /tmp/artifacts diff --git a/.github/workflows/2-test-stand-alone.yml b/.github/workflows/2-test-stand-alone.yml deleted file mode 100755 index dcef6ab64..000000000 --- a/.github/workflows/2-test-stand-alone.yml +++ /dev/null @@ -1,70 +0,0 @@ ---- -name: ๐Ÿ’ป Stand Alone Tests - -on: - workflow_call: - - -jobs: - stand-alone-test: - name: ๐Ÿ“ Stand Alone Test Suite - runs-on: ${{ matrix.os }}-latest - strategy: - fail-fast: false - matrix: - os: [ubuntu, macos] - python-version: ["3.8", "3.9", "3.10"] - steps: - - name: ๐Ÿ„ Got git? - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - # Get history and tags for SCM versioning to work - - name: ๐Ÿ“ฉ Checkout the Source - run: | - git fetch --prune --unshallow || true - git fetch --depth=1 origin +refs/tags/*:refs/tags/* - # Verify .git folder - if [ ! -d "./.git" ]; then - echo "Expected ./.git folder to exist" - exit 1 - fi - - - name: ๐Ÿ Switch Python ${{ matrix.python-version }} - uses: actions/setup-python@v4 - with: - python-version: ${{ matrix.python-version }} - - - name: ๐ŸŒฑ Setup Test Enviroment - run: | - python -m pip install --upgrade pip - python -m pip install --upgrade build - - - name: โš™๏ธ Installing Armory - shell: bash - run: | - pip install --no-compile --editable '.[developer,engine,pytorch]' - armory configure --use-defaults - - - name: ๐Ÿคž Run Host Configuration Tests - env: - PYTEST_PARAMS: --exitfirst --suppress-no-test-exit-code - shell: bash - run: | - echo "Testing Python Version: ${{ matrix.python-version }}" - pytest -c pyproject.toml -s ./tests/unit/test_configuration.py - - - name: ๐Ÿคž Run Stand Alone No-Docker & Unit Tests - env: - PYTEST_PARAMS: --exitfirst --suppress-no-test-exit-code - shell: bash - run: | - pytest -c pyproject.toml -m "not docker_required and unit" ./tests/ - - - name: ๐Ÿคž Run Stand Alone End-to-End Tests - env: - PYTEST_PARAMS: --exitfirst --suppress-no-test-exit-code - shell: bash - run: | - pytest -c pyproject.toml -s ./tests/end_to_end/test_no_docker.py diff --git a/.github/workflows/3-test-docker.yml b/.github/workflows/3-test-docker.yml deleted file mode 100755 index ac6b59061..000000000 --- a/.github/workflows/3-test-docker.yml +++ /dev/null @@ -1,93 +0,0 @@ ---- -name: ๐Ÿค– Docker Tests - -on: workflow_call - - -env: - DOCKER_BUILDKIT: 1 - - -jobs: - docker-armory-unit: - name: โ˜๏ธ Docker Armory Image Tests - runs-on: ubuntu-latest - steps: - - name: ๐Ÿ„ checkout armory full depth with tags for scm - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - - name: ๐Ÿ Use Python 3.9 - uses: actions/setup-python@v4 - with: - python-version: 3.9 - - - name: โš™๏ธ Install Armory - shell: bash - run: | - pip install . - armory configure --use-defaults - - - name: ๐Ÿšง Build the Container - run: | - python docker/build.py --framework armory - - - name: ๐Ÿคž Run Image tests - run: | - IMAGE_VERSION=`armory --show-docker-version-tag` - docker run \ - --rm \ - --workdir /armory-repo \ - twosixarmory/armory:${IMAGE_VERSION} \ - pytest \ - -c /armory-repo/pyproject.toml \ - -m "not docker_required and unit" \ - ./tests/ - - - docker-deepspeech-unit: - name: โ˜๏ธ Docker Deepspeech Image Tests - runs-on: ubuntu-latest - steps: - - name: ๐Ÿ„ checkout armory full depth with tags for scm - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - - name: ๐Ÿ Use Python 3.9 - uses: actions/setup-python@v4 - with: - python-version: 3.9 - - - name: โš™๏ธ Installing Armory - shell: bash - run: | - pip install . - armory configure --use-defaults - - - name: ๐Ÿšง Build the Container - run: | - python docker/build.py --framework pytorch-deepspeech - - - name: ๐Ÿคž Run Image tests - run: | - IMAGE_VERSION=`armory --show-docker-version-tag` - - docker run \ - --rm \ - --workdir /armory-repo \ - twosixarmory/pytorch-deepspeech:${IMAGE_VERSION} \ - pytest \ - -c /armory-repo/pyproject.toml \ - -m "not docker_required and unit" \ - ./tests/ - - docker run \ - --rm \ - --workdir /armory-repo \ - twosixarmory/pytorch-deepspeech:${IMAGE_VERSION} \ - pytest \ - -c /armory-repo/pyproject.toml \ - -m "pytorch_deepspeech" \ - ./tests/ diff --git a/.github/workflows/ci_test.yml b/.github/workflows/ci_test.yml deleted file mode 100644 index a12789096..000000000 --- a/.github/workflows/ci_test.yml +++ /dev/null @@ -1,35 +0,0 @@ ---- -name: ๐Ÿ›๐Ÿ“ฆ Build & Test - -on: - workflow_dispatch: - - # push: - # branches: - # - master - # - develop - # - 'v[0-9]+.[0-9]+.[0-9]+' # release branches have the form v1.9.x - # - 'rc[0-9]+.[0-9]+.[0-9]+' # release candidate branches - - # pull_request: - # branches: - # - master - # - develop - # - 'v[0-9]+.[0-9]+.[0-9]+' # release branches have the form v1.9.x - # - 'rc[0-9]+.[0-9]+.[0-9]+' # release candidate branches - - -env: - DOCKER_BUILDKIT: 1 - - -jobs: - scan-lint-build: - uses: ./.github/workflows/1-scan-lint-build.yml - - test-stand-alone-builds: - needs: scan-lint-build - uses: ./.github/workflows/2-test-stand-alone.yml - - test-docker-builds: - uses: ./.github/workflows/3-test-docker.yml diff --git a/.github/workflows/scenario-runner.yml b/.github/workflows/scenario-runner.yml deleted file mode 100644 index 0d08a234f..000000000 --- a/.github/workflows/scenario-runner.yml +++ /dev/null @@ -1,92 +0,0 @@ ---- -name: ๐Ÿš‚ Scenario Runner - -on: - # Trigger update - # push: - - workflow_dispatch: - inputs: - experiments_dir: - type: choice - description: 'Experiments Directory' - required: false - default: eval6 - options: - - eval6 - - eval5 - - eval1-4 - - debug_enabled: - type: boolean - description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)' - required: false - default: false - - -jobs: - matrix_generator: - name: Matrix Generator - runs-on: [self-hosted] - outputs: - matrix: ${{ steps.generate-matrix.outputs.matrix }} - steps: - - name: ๐Ÿ„ Got git? - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - - name: ๐Ÿ‘ฉโ€๐Ÿ’ป Generating Matrix - id: generate-matrix - run: | - echo "::set-output name=matrix::$(find ./scenario_configs/${{ github.event.inputs.experiments_dir }} -type f -name "*.json" | jq -cnR '[inputs | select(length>0)]')" - - - matrix_job: - runs-on: [self-hosted] - needs: matrix_generator - strategy: - fail-fast: false - matrix: - scenario_path: ${{ fromJson(needs.matrix_generator.outputs.matrix) }} - steps: - - name: ๐Ÿ„ Got git? - uses: actions/checkout@v3 - - - name: ๐Ÿ Setup Environment - uses: ./.github/actions/evaluations_environment_setup - - - name: โš’๏ธ Install Prerequisites - run: | - source .venv/bin/activate - - - name: ๐Ÿš€ Run Scenario Evaluation - timeout-minutes: 30 - env: - ARMORY_INSTALL: "/tmp" - HOME: "/tmp" - run: | - mkdir -p "/tmp/logs" - - mkdir -p "${HOME}/armory/outputs/" - mkdir -p "${HOME}/.armory/" - - armory configure --use-defaults - - pytest \ - -c pyproject.toml \ - --verbose \ - -s ./tests/end_to_end/test_e2e_scenarios.py \ - --scenario-path ${{ matrix.scenario_path }} \ - --github-ci | tee "scenario_evaluation.log" - - - - name: ๐Ÿ“ Archiving Artifacts - uses: actions/upload-artifact@v3 - # if: ${{ !failure() }} - continue-on-error: true - with: - name: evaluation-artifacts - retention-days: 1 - path: | - /tmp/.armory/outputs/ diff --git a/.github/workflows/self-hosted.yml b/.github/workflows/self-hosted.yml deleted file mode 100644 index 2f2ba207a..000000000 --- a/.github/workflows/self-hosted.yml +++ /dev/null @@ -1,71 +0,0 @@ -# this is derived from 2-test-stand-alone.yml with -# 1. uses a self-hosted runner -# 2. removes the python version matrix and non-linux tasks - -# TODO: there are likely all kinds of statefullness problems because the -# self hosted runner is not-ephemeral ---- -name: self-hosted tests - -on: - workflow_dispatch: - - -jobs: - stand-alone-test: - name: quick-test on self-hosted - runs-on: [self-hosted] - steps: - - name: checkout - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - # Get history and tags for SCM versioning to work - - name: git checkout - run: | - git fetch --prune --unshallow || true - git fetch --depth=1 origin +refs/tags/*:refs/tags/* - # Verify .git folder - if [ ! -d "./.git" ]; then - echo "Expected ./.git folder to exist" - exit 1 - fi - - - name: using python 3.8 - uses: actions/setup-python@v4 - with: - python-version: 3.8 - - - name: Activate virtualenv - run: | - now=venv-$(date -Ins) - python -m venv $now - source $now/bin/activate - echo PATH=$PATH >> $GITHUB_ENV - - - - name: ๐ŸŒฑ Setup Test Enviroment - run: | - python -m pip install --upgrade pip build - - - name: โš™๏ธ Installing Armory - shell: bash - run: | - pip install --no-compile --editable '.[developer,engine,pytorch]' - armory configure --use-defaults - - - name: check host configuration - shell: bash - run: | - pytest -c pyproject.toml -s ./tests/unit/test_configuration.py - - - name: standalone tests - shell: bash - run: | - pytest -c pyproject.toml -m "not docker_required and unit" ./tests/ - - - name: ๐Ÿคž Run Stand Alone End-to-End Tests - shell: bash - run: | - pytest -c pyproject.toml -s ./tests/end_to_end/test_no_docker.py From 0f4cf50818a8ab20002e017fb24a7b18aa221018 Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 15:22:03 -0400 Subject: [PATCH 09/10] Set up python version matrix for unit tests --- .github/workflows/ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0204db035..967cd056b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,6 +61,10 @@ jobs: name: ๐Ÿงช Unit Tests runs-on: ubuntu-latest needs: code-linting + strategy: + fail-fast: false + matrix: + python-version: ["3.8", "3.9", "3.10", "3.11"] steps: - name: Checkout uses: actions/checkout@v3 @@ -68,7 +72,7 @@ jobs: - name: Setup Python uses: actions/setup-python@v4 with: - python-version: 3.8 + python-version: ${{ matrix.python-version }} - name: Install run: make install From ed65edda4fa5e02bedd08c634bcceadd1cf470bf Mon Sep 17 00:00:00 2001 From: Kyle Treubig Date: Thu, 19 Oct 2023 16:00:58 -0400 Subject: [PATCH 10/10] Replace emojis --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 967cd056b..aa9554d8f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,5 @@ --- -name: ๐Ÿ›๐Ÿ“ฆ Build & Test +name: ๐Ÿšง Build & Test on: workflow_dispatch: @@ -12,7 +12,7 @@ on: jobs: code-linting: - name: ๐Ÿ“ก Code Linting + name: ๐Ÿงน Code Linting runs-on: ubuntu-latest steps: - name: Checkout @@ -31,7 +31,7 @@ jobs: static-analysis: - name: ๐Ÿšง Static Analysis + name: ๐Ÿ” Static Analysis runs-on: ubuntu-latest needs: code-linting steps: