Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Convert Issue templates to Forms #402

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Convert Issue templates to Forms #402

merged 3 commits into from
Sep 2, 2021

Conversation

StephenBrown2
Copy link
Contributor

@StephenBrown2 StephenBrown2 commented Sep 1, 2021

Checklist
I have read the guidelines in CONTRIBUTING.md yes
Include my name in CONTRIBUTORS.md no
I am affiliated with this alternative (if applicable) N/A

Details

I recently noticed in another repo that GitHub has the ability to use forms for its issue templates now, and I thought it might significantly help in the quality of submitted issues to this repository and reduce frustration on both contributor and maintainer's sides.

New Alternative

Here is the new "New Alternative" view (some fields have been made required, and the CONTIBUTING/CONTRIBUTORS.md files are links again, I fixed that after taking the screenshot):
New Issue · degoogle

and the resulting issue after partially filling out the template:
NEW  Alternative · Issue · degoogle

Fix Alternative

Here is the new look for "Fix Alternative":
Fix Issue · degoogle

Remove Alternative

Here is the "Remove Alternative":
Remove Issue · degoogle

Other

Here I am of two minds. Historically "Other" has been handled by issues with the other label, and so the new view does the same:
Other Issue · degoogle

However, GitHub does have "Discussions", which can either be converted from Issues (and even in bulk/automatically from a particular label), or you can direct users to start a discussion straight from the Issue template chooser, so I've added that as an option as well:
Choose Issue · degoogle

I only expect one of three options to be taken:

  1. Issues with the other label are converted to Discussions, and done so automatically upon creation
  2. The "Other" issue template is removed and users are directed to the discussions page straight away
  3. Discussions are not enabled for this repo and @tycrek continues with using other tagged issues

The benefit of keeping the issues tagged with other is that you can still take advantage of the form and require some structure (and checking the box that the user has read the contribution guidelines) before starting a discussion. In testing it told me it would not automatically convert issues with that label in the future, so perhaps you should stick with option #2 or #3.

I've reverted the discussion pointer in 0a0a6e1 so this can be merged as is. If you would like to enable discussions the first two options can be decided on.

Obviously very open to feedback on this unsolicited change suggestion, I only hope it's helpful!

@tycrek tycrek added the enhancement New feature or request label Sep 1, 2021
@tycrek tycrek self-assigned this Sep 1, 2021
@tycrek
Copy link
Owner

tycrek commented Sep 1, 2021

@StephenBrown2 thanks so much for writing these! I had considered using them, but the main thing preventing me was that they don't yet properly work on GitHub's app. They work in mobile browsers though, so I'm definitely up for merging this!

One thing that would be nice to have though: automatically attach the label to the Form, similar to what I did here: https://github.com/tycrek/ass/blame/master/.github/ISSUE_TEMPLATE/feature-request.yml#L4

Regarding Other...

I think option 2 is a good way to go about this:

The "Other" issue template is removed and users are directed to the discussions page straight away

Though I don't have much experience with Discussions yet. What would you suggest?

@StephenBrown2
Copy link
Contributor Author

StephenBrown2 commented Sep 1, 2021

One thing that would be nice to have though: automatically attach the label to the Form, similar to what I did here: tycrek/ass@master/.github/ISSUE_TEMPLATE/feature-request.yml#L4 (blame)

I did make sure to keep the labels you already had, but they don't show up in my screenshots because I didn't have those labels created before making the issues:

If you go with Option 2, you'll need to enable the Discussions feature on the repo, and I would suggest maybe converting all the existing "other" tagged issues to discussions so that folks can find them once being directed there (Option 1a). I'm not sure why the auto-converting said it wouldn't work for future issues (Option 1b) when I tried in my fork, but it won't matter too much if you move to discussions for non-CRUD Issues (Option 2).

I've had a bit of experience with discussions in the python-httpx repository, and GitHub gives you several categories to choose from off the bat, so I think it's a useful addition and better alternative to tagging open-ended issues with 'other'.

I'll go ahead and remove the Other template and re-enable the link to discussions.

@tycrek tycrek merged commit 13ced68 into tycrek:master Sep 2, 2021
@tycrek
Copy link
Owner

tycrek commented Sep 2, 2021

Thanks again @StephenBrown2 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants