Skip to content

Commit 92f00cd

Browse files
authored
Merge branch 'master' into chriskrycho-patch-1
2 parents 4d6dfbb + 9e0fff4 commit 92f00cd

File tree

28 files changed

+4311
-5581
lines changed

28 files changed

+4311
-5581
lines changed

.eslintrc.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-env node */
12
module.exports = {
23
root: true,
34
parser: '@typescript-eslint/parser',
@@ -11,7 +12,7 @@ module.exports = {
1112
browser: true,
1213
},
1314
rules: {
14-
"prettier/prettier": "error"
15+
'prettier/prettier': 'error',
1516
},
1617
settings: {
1718
node: {
@@ -43,14 +44,10 @@ module.exports = {
4344
node: true,
4445
},
4546
plugins: ['node'],
46-
rules: Object.assign(
47-
{},
48-
require('eslint-plugin-node').configs.recommended.rules,
49-
{
50-
// add your custom rules and overrides for node files here
51-
'ember/avoid-leaking-state-in-ember-objects': 'off',
52-
}
53-
),
47+
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
48+
// add your custom rules and overrides for node files here
49+
'ember/avoid-leaking-state-in-ember-objects': 'off',
50+
}),
5451
},
5552

5653
// test files

CHANGELOG.md

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,35 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
66

77
## [Unreleased]
88

9+
## [4.0.0-alpha.1] - 2020-01-18
10+
11+
### Breaking 💥
12+
13+
- Drop support for Node 8 ([#1017])
14+
- Don't configure Babel for TS transpilation ([#1018])
15+
16+
### Under the hood 🚗
17+
18+
- Upgrade [✨ Prettier ✨](https://prettier.io) to a version that supports optional chaining and nullish coalescing ([#1018])
19+
- Add test for optional chaining and nullish coalescing ([#1018])
20+
- Add test for class field declaration ([#1018])
21+
22+
[#1017]: https://github.com/typed-ember/ember-cli-typescript/pull/1017
23+
[#1018]: https://github.com/typed-ember/ember-cli-typescript/pull/1018
24+
25+
## [3.1.4] - 2020-05-29
26+
27+
### Fixed 🔧
28+
29+
- Use temp dir in project for precompile ([#1153])
30+
31+
### Under the hood 🚗
32+
33+
- Bumped [52 dependency versions][3.1.4-deps-bumps]
34+
35+
[#1153]: https://github.com/typed-ember/ember-cli-typescript/pull/1153
36+
[3.1.4-deps-bumps]: https://github.com/typed-ember/ember-cli-typescript/pulls?q=is%3Apr+is%3Amerged+base%3Amaster+merged%3A2020-01-22T13%3A00%3A00-0600..2020-05-29T11%3A00%3A00-0500+chore%28deps%29+in%3Atitle+
37+
938
## [3.1.3] - 2020-01-22
1039

1140
### Fixed 🔧
@@ -622,7 +651,13 @@ We now use Babel 7's support for TypeScript to build apps and addons. Most of th
622651
* Basic, semi-working functionality.
623652

624653
[ember-cli-typify]: https://github.com/winding-lines/ember-cli-typify
625-
[unreleased]: https://github.com/typed-ember/ember-cli-typescript/compare/v3.1.3...HEAD
654+
[unreleased]: https://github.com/typed-ember/ember-cli-typescript/compare/v4.0.0-alpha.1...HEAD
655+
<!--
656+
This is correctly compared against v3.1.3 because it was released on a branch
657+
before v3.1.4 was released.
658+
-->
659+
[4.0.0-alpha.1]: https://github.com/typed-ember/ember-cli-typescript/compare/v3.1.3...v4.0.0-alpha.1
660+
[3.1.4]: https://github.com/typed-ember/ember-cli-typescript/compare/v3.1.3...v3.1.4
626661
[3.1.3]: https://github.com/typed-ember/ember-cli-typescript/compare/v3.1.2...v3.1.3
627662
[3.1.2]: https://github.com/typed-ember/ember-cli-typescript/compare/v3.1.1...v3.1.2
628663
<!--

blueprint-files/ember-cli-typescript/__config_root__/config/environment.d.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ export default config;
22

33
/**
44
* Type declarations for
5-
* import config from './config/environment'
6-
*
7-
* For now these need to be managed by the developer
8-
* since different ember addons can materialize new entries.
5+
* import config from 'my-app/config/environment'
96
*/
107
declare const config: {
11-
environment: any;
8+
environment: string;
129
modulePrefix: string;
1310
podModulePrefix: string;
1411
locationType: string;
1512
rootURL: string;
13+
APP: Record<string, unknown>;
1614
};

config/deploy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* eslint-env node */
22
'use strict';
33

4-
module.exports = function(deployTarget) {
4+
module.exports = function (deployTarget) {
55
let ENV = {
66
build: {},
77
// include other plugin configuration that applies to all deploy targets here

config/environment.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
22

3-
module.exports = function(/* environment, appConfig */) {
3+
module.exports = function (/* environment, appConfig */) {
44
return {};
55
};

ember-cli-build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
44

5-
module.exports = function(defaults) {
5+
module.exports = function (defaults) {
66
let app = new EmberAddon(defaults, {
77
'ember-cli-babel': {
88
throwUnlessParallelizable: true,

package.json

Lines changed: 49 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ember-cli-typescript",
3-
"version": "3.1.3",
3+
"version": "4.0.0-alpha.1",
44
"description": "Allow ember apps to use typescript files.",
55
"keywords": [
66
"ember-addon",
@@ -39,114 +39,107 @@
3939
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s -u"
4040
},
4141
"dependencies": {
42-
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.4.4",
43-
"@babel/plugin-proposal-optional-chaining": "^7.6.0",
44-
"@babel/plugin-transform-typescript": "~7.8.0",
4542
"ansi-to-html": "^0.6.6",
4643
"broccoli-stew": "^3.0.0",
4744
"debug": "^4.0.0",
48-
"ember-cli-babel-plugin-helpers": "^1.0.0",
49-
"execa": "^3.0.0",
50-
"fs-extra": "^8.0.0",
45+
"execa": "^4.0.0",
46+
"fs-extra": "^9.0.1",
5147
"resolve": "^1.5.0",
5248
"rsvp": "^4.8.1",
53-
"semver": "^6.3.0",
49+
"semver": "^7.3.2",
5450
"stagehand": "^1.0.0",
55-
"walk-sync": "^2.0.0"
51+
"walk-sync": "^2.2.0"
5652
},
5753
"devDependencies": {
58-
"@commitlint/cli": "8.3.5",
59-
"@commitlint/config-conventional": "8.3.4",
54+
"@commitlint/cli": "9.0.1",
55+
"@commitlint/config-conventional": "9.0.1",
6056
"@ember/optional-features": "1.3.0",
6157
"@typed-ember/renovate-config": "1.2.1",
6258
"@types/capture-console": "1.0.0",
63-
"@types/chai": "4.2.9",
59+
"@types/chai": "4.2.11",
6460
"@types/chai-as-promised": "7.1.2",
6561
"@types/console-ui": "2.2.3",
6662
"@types/core-object": "3.0.1",
6763
"@types/debug": "4.1.5",
68-
"@types/ember": "3.1.1",
69-
"@types/ember-qunit": "3.4.7",
64+
"@types/ember": "3.16.0",
65+
"@types/ember-qunit": "3.4.9",
7066
"@types/esprima": "4.0.2",
71-
"@types/express": "4.17.2",
72-
"@types/fs-extra": "8.1.0",
73-
"@types/got": "8.3.5",
74-
"@types/mocha": "7.0.1",
75-
"@types/node": "9.6.55",
76-
"@types/qunit": "2.9.0",
77-
"@types/resolve": "1.14.0",
78-
"@types/semver": "6.2.1",
79-
"@types/tmp": "0.1.0",
80-
"@typescript-eslint/eslint-plugin": "2.21.0",
81-
"@typescript-eslint/parser": "2.21.0",
67+
"@types/express": "4.17.6",
68+
"@types/fs-extra": "9.0.1",
69+
"@types/got": "9.6.11",
70+
"@types/mocha": "7.0.2",
71+
"@types/node": "14.0.14",
72+
"@types/qunit": "2.9.1",
73+
"@types/resolve": "1.17.1",
74+
"@types/semver": "7.3.1",
75+
"@typescript-eslint/eslint-plugin": "3.5.0",
76+
"@typescript-eslint/parser": "3.5.0",
8277
"broccoli-asset-rev": "3.0.0",
8378
"broccoli-node-api": "1.7.0",
84-
"broccoli-plugin": "4.0.1",
79+
"broccoli-plugin": "4.0.3",
8580
"capture-console": "1.0.1",
8681
"co": "4.6.0",
8782
"commitlint-azure-pipelines-cli": "1.0.3",
88-
"conventional-changelog-cli": "2.0.31",
89-
"ember-cli": "3.16.0",
83+
"conventional-changelog-cli": "2.0.34",
84+
"ember-cli": "3.19.0",
9085
"ember-cli-addon-docs": "ember-learn/ember-cli-addon-docs#4f5bfd11",
9186
"ember-cli-addon-docs-esdoc": "0.2.3",
9287
"ember-cli-app-version": "3.2.0",
93-
"ember-cli-babel": "7.18.0",
88+
"ember-cli-babel": "7.21.0",
9489
"ember-cli-blueprint-test-helpers": "0.19.2",
9590
"ember-cli-dependency-checker": "3.2.0",
9691
"ember-cli-deploy": "1.0.2",
9792
"ember-cli-deploy-build": "2.0.0",
9893
"ember-cli-deploy-git": "1.3.4",
9994
"ember-cli-deploy-git-ci": "1.0.1",
100-
"ember-cli-htmlbars": "4.2.3",
95+
"ember-cli-htmlbars": "5.2.0",
10196
"ember-cli-inject-live-reload": "2.0.2",
102-
"ember-cli-release": "0.2.9",
10397
"ember-cli-sri": "2.1.1",
10498
"ember-cli-typescript-blueprints": "3.0.0",
10599
"ember-cli-uglify": "3.0.0",
106-
"ember-cli-update": "0.52.1",
100+
"ember-cli-update": "0.54.6",
107101
"ember-disable-prototype-extensions": "1.1.3",
108102
"ember-export-application-global": "2.0.1",
109103
"ember-load-initializers": "2.1.1",
110104
"ember-maybe-import-regenerator": "0.1.6",
111105
"ember-qunit": "4.6.0",
112-
"ember-resolver": "7.0.0",
113-
"ember-source": "3.16.3",
106+
"ember-resolver": "8.0.0",
107+
"ember-source": "3.19.0",
114108
"ember-try": "1.4.0",
115-
"eslint": "6.8.0",
116-
"eslint-config-prettier": "6.10.0",
117-
"eslint-plugin-ember": "7.8.1",
118-
"eslint-plugin-node": "11.0.0",
119-
"eslint-plugin-prettier": "3.1.2",
109+
"eslint": "7.3.1",
110+
"eslint-config-prettier": "6.11.0",
111+
"eslint-plugin-ember": "8.9.0",
112+
"eslint-plugin-node": "11.1.0",
113+
"eslint-plugin-prettier": "3.1.4",
120114
"esprima": "4.0.1",
121-
"fixturify": "1.3.0",
122-
"got": "10.6.0",
123-
"handlebars": "4.7.3",
124-
"husky": "4.2.3",
115+
"fixturify": "2.1.0",
116+
"got": "11.3.0",
117+
"handlebars": "4.7.6",
118+
"husky": "4.2.5",
125119
"in-repo-a": "link:tests/dummy/lib/in-repo-a",
126120
"in-repo-b": "link:tests/dummy/lib/in-repo-b",
127121
"loader.js": "4.7.0",
128-
"mocha": "7.1.0",
129-
"prettier": "1.18.2",
130-
"prettier-eslint": "9.0.1",
131-
"qunit-dom": "1.0.0",
132-
"testdouble": "3.13.0",
133-
"tmp": "0.1.0",
134-
"ts-node": "8.6.2",
122+
"mocha": "8.0.1",
123+
"prettier": "2.0.5",
124+
"prettier-eslint": "11.0.0",
125+
"qunit-dom": "1.2.0",
126+
"rimraf": "3.0.2",
127+
"testdouble": "3.16.0",
128+
"ts-node": "8.10.2",
135129
"typescript": "3.7.5"
136130
},
137131
"resolutions": {
138-
"@types/ember": "3.1.1",
139-
"@types/ember__string": "3.0.6",
132+
"@types/ember": "3.1.2",
133+
"@types/ember__string": "3.0.8",
140134
"hawk": "7"
141135
},
142136
"engines": {
143-
"node": "8.* || >= 10.*"
137+
"node": "10.* || >= 12.*"
144138
},
145139
"ember-addon": {
146140
"configPath": "tests/dummy/config",
147141
"before": [
148-
"broccoli-watcher",
149-
"ember-cli-babel"
142+
"broccoli-watcher"
150143
]
151144
},
152145
"husky": {
@@ -164,6 +157,6 @@
164157
},
165158
"volta": {
166159
"node": "10.19.0",
167-
"yarn": "1.22.0"
160+
"yarn": "1.22.4"
168161
}
169162
}

rfcs/0000-template.md

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
- Start Date: (fill me in with today's date, YYYY-MM-DD)
2+
- Relevant Team(s): (fill this in with the [team(s)](README.md#relevant-teams) to which this RFC applies)
3+
- RFC PR: (after opening the RFC PR, update this with a link to it and update the file name)
4+
- Tracking: (leave this empty)
5+
6+
# <RFC title>
7+
8+
## Summary
9+
10+
> One paragraph explanation of the feature.
11+
12+
## Motivation
13+
14+
> Why are we doing this? What use cases does it support? What is the expected
15+
outcome?
16+
17+
## Detailed design
18+
19+
> This is the bulk of the RFC.
20+
21+
> Explain the design in enough detail for somebody
22+
familiar with the framework to understand, and for somebody familiar with the
23+
implementation to implement. This should get into specifics and corner-cases,
24+
and include examples of how the feature is used. Any new terminology should be
25+
defined here.
26+
27+
## How we teach this
28+
29+
> What names and terminology work best for these concepts and why? How is this
30+
idea best presented? As a continuation of existing Ember patterns, or as a
31+
wholly new one?
32+
33+
> Would the acceptance of this proposal mean the Ember guides must be
34+
re-organized or altered? Does it change how Ember is taught to new users
35+
at any level?
36+
37+
> How should this feature be introduced and taught to existing Ember
38+
users?
39+
40+
## Drawbacks
41+
42+
> Why should we *not* do this? Please consider the impact on teaching Ember,
43+
on the integration of this feature with other existing and planned features,
44+
on the impact of the API churn on existing apps, etc.
45+
46+
> There are tradeoffs to choosing any path, please attempt to identify them here.
47+
48+
## Alternatives
49+
50+
> What other designs have been considered? What is the impact of not doing this?
51+
52+
> This section could also include prior art, that is, how other frameworks in the same domain have solved this problem.
53+
54+
## Unresolved questions
55+
56+
> Optional, but suggested for first drafts. What parts of the design are still
57+
TBD?

0 commit comments

Comments
 (0)