Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude 'target' and '.DS_Store' from checkstyle coverage #390

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

alexjpwalker
Copy link
Member

What is the goal of this PR?

We now exclude target and .DS_Store from checkstyle coverage tests.

What are the changes implemented in this PR?

target is typically a generated folder (e.g. by cargo). .DS_Store is generated by Finder on a Mac. They should be excluded from checkstyle coverage.

NB: Fixing #253 would remove the need for this PR, but it's harder to do.

@typedb-bot
Copy link
Member

typedb-bot commented Nov 18, 2022

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@lolski lolski merged commit e2b0978 into typedb:master Nov 18, 2022
jamesreprise pushed a commit to jamesreprise/vaticle-dependencies that referenced this pull request Dec 5, 2022
## What is the goal of this PR?

We now exclude `target` and `.DS_Store` from checkstyle coverage tests.

## What are the changes implemented in this PR?

`target` is typically a generated folder (e.g. by `cargo`). `.DS_Store`
is generated by Finder on a Mac. They should be excluded from checkstyle
coverage.

NB: Fixing typedb#253 would
remove the need for this PR, but it's harder to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants