Skip to content
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.

Examples should be kept outside main source #36

Closed
jmsfltchr opened this issue Jan 31, 2019 · 0 comments
Closed

Examples should be kept outside main source #36

jmsfltchr opened this issue Jan 31, 2019 · 0 comments
Assignees
@jmsfltchr
Labels
status: solved
Milestone
v0.1

Comments

@jmsfltchr
Copy link
Contributor

The animal trade example currently sits in a sub-directory of kglib, which means it is accessible when importing via pip. This should not be the case.
@jmsfltchr jmsfltchr added this to the v0.1 milestone Jan 31, 2019
@jmsfltchr jmsfltchr self-assigned this Jan 31, 2019
@jmsfltchr jmsfltchr mentioned this issue Feb 4, 2019
Merged
lolski pushed a commit that referenced this issue Feb 4, 2019
@jmsfltchr
CI/CD improvements (#39)
e0907a0 
- Adds an end-to-end test that depends upon `grakn-kglib` from the PyPi test server
- Splits out example from main source
-Updates READMEs, now there is one for the KGCN example, one for KGCN general usage, and one for the whole repo
- Updates some example schema used for the Vienna meetup 29/01/2019

Addresses #35 #36 #37 #31 #30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmsfltchr jmsfltchr

Labels
status: solved
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
2 participants
@haikalpribadi @jmsfltchr