Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explanation: checking for unassigned relations is not done when first explanation is joint #299

Closed
sorsaffari opened this issue Jun 18, 2020 · 0 comments · Fixed by #303
Closed

Explanation: checking for unassigned relations is not done when first explanation is joint #299

sorsaffari opened this issue Jun 18, 2020 · 0 comments · Fixed by #303
Assignees
@sorsaffari
Labels
priority: high status: solved
Milestone
1.3.2

Comments

@sorsaffari
Copy link

No description provided.

@sorsaffari sorsaffari self-assigned this Jun 18, 2020
@sorsaffari sorsaffari added this to the 1.3.2 milestone Jun 18, 2020
@sorsaffari sorsaffari mentioned this issue Jun 18, 2020
Merged
sorsaffari pushed a commit that referenced this issue Jun 19, 2020
Fixes a bug where getRule gets run on a joint explanation (#300)
93ad18c 
## What is the goal of this PR?
Explanation now works as expected when the first explanation is joint. This marks the 1.3.1 release.

## What are the changes implemented in this PR?
While introducing this fix I came to realise that the _unassigned variables_ error message will not be displayed when the target explanation is within the answers of the joint explanation. I have created an issue for it with high priority: #299
@sorsaffari sorsaffari mentioned this issue Jun 22, 2020
Merged
sorsaffari pushed a commit that referenced this issue Jun 30, 2020
Displays the unassigned relation error in case of a join explanation (#…
f69f2de 
…303)

## What is the goal of this PR?
The checking of unassigned relations in the when body of a rule that's being explained, now is also performed on the underlying explanation object (where the first retrieved explanation is of type join)

## What are the changes implemented in this PR?
resolves #299
sorsaffari pushed a commit that referenced this issue Jun 30, 2020
@sorsaffari
Displays the unassigned relation error in case of a join explanation (#…
84eddcf 
…303)

## What is the goal of this PR?
The checking of unassigned relations in the when body of a rule that's being explained, now is also performed on the underlying explanation object (where the first retrieved explanation is of type join)

## What are the changes implemented in this PR?
resolves #299
sorsaffari pushed a commit that referenced this issue Jul 2, 2020
@sorsaffari
Displays the unassigned relation error in case of a join explanation (#…
458ca22 
…303)

## What is the goal of this PR?
The checking of unassigned relations in the when body of a rule that's being explained, now is also performed on the underlying explanation object (where the first retrieved explanation is of type join)

## What are the changes implemented in this PR?
resolves #299
sorsaffari pushed a commit that referenced this issue Jul 13, 2020
@sorsaffari
Displays the unassigned relation error in case of a join explanation (#…
e7d46ef 
…303)

## What is the goal of this PR?
The checking of unassigned relations in the when body of a rule that's being explained, now is also performed on the underlying explanation object (where the first retrieved explanation is of type join)

## What are the changes implemented in this PR?
resolves #299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorsaffari sorsaffari

Labels
priority: high status: solved
Projects
None yet
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

Displays the unassigned relation error in case of a join explanation sorsaffari/workbase
2 participants
@sorsaffari @grabl