Respect Python version given in ini file #92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Jan 1, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thanks! Looks good, do you know any good ways to write a test for this feature? 🤔
Contributor
Author
|
@sobolevn I opened a separate PR based on your response in the issue, that simply changes to not never set Which PR do you think makes more sense? I didn't find any tests for the rest of the logic of merging config etc. I think it would be nice to have such tests, I think it should be fairly easy to achieve by mocking open and checking the output is as expected based on the input. |
Member
|
Replaced by #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91