From 3d9c390e1359488b5de902db6faa83227d03cd87 Mon Sep 17 00:00:00 2001
From: Kailuo Wang <kailuo.wang@gmail.com>
Date: Mon, 20 Nov 2017 16:31:28 -0500
Subject: [PATCH] move sentinel to companion

---
 core/src/main/scala/cats/Foldable.scala | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/core/src/main/scala/cats/Foldable.scala b/core/src/main/scala/cats/Foldable.scala
index 218734428e..4247dc2f52 100644
--- a/core/src/main/scala/cats/Foldable.scala
+++ b/core/src/main/scala/cats/Foldable.scala
@@ -4,6 +4,7 @@ import scala.collection.mutable
 import cats.instances.either._
 import cats.instances.long._
 import simulacrum.typeclass
+import Foldable.sentinel
 
 /**
  * Data structures that can be folded to a summary value.
@@ -214,15 +215,14 @@ import simulacrum.typeclass
         case Right(_) => None
       }
 
-  def collectFirst[A, B](fa: F[A])(pf: PartialFunction[A, B]): Option[B] = {
-    // trick from TravsersableOnce
-    val sentinel: Function1[A, Any] = new scala.runtime.AbstractFunction1[A, Any]{ def apply(a: A) = this }
+  def collectFirst[A, B](fa: F[A])(pf: PartialFunction[A, B]): Option[B] =
     foldRight(fa, Eval.now(Option.empty[B])) { (a, lb) =>
+      // trick from TravsersableOnce
       val x = pf.applyOrElse(a, sentinel)
       if (x.asInstanceOf[AnyRef] ne sentinel) Eval.now(Some(x.asInstanceOf[B]))
       else lb
     }.value
-  }
+
 
   /**
    * Like `collectFirst` from `scala.collection.Traversable` but takes `A => Option[B]`
@@ -584,6 +584,8 @@ import simulacrum.typeclass
 }
 
 object Foldable {
+  private val sentinel: Function1[Any, Any] = new scala.runtime.AbstractFunction1[Any, Any]{ def apply(a: Any) = this }
+
   def iterateRight[A, B](iterable: Iterable[A], lb: Eval[B])(f: (A, Eval[B]) => Eval[B]): Eval[B] = {
     def loop(it: Iterator[A]): Eval[B] =
       Eval.defer(if (it.hasNext) f(it.next, loop(it)) else lb)