added a migration note to the release notes IRT tuple instances #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 83.92%
@@ master #1009 diff @@
==========================================
Files 368 368
Lines 2376 2376
Methods 2169 2169
Messages 0 0
Branches 19 19
==========================================
+ Hits 1992 1994 +2
+ Misses 384 382 -2
Partials 0 0
|
| @@ -6,10 +6,12 @@ Version 0.5.0 is the fifth release. | |||
|
|
|||
| This release includes some API changes: | |||
|
|
|||
| `cats.laws.discipline.eq` no longer provides `Eq` instances for `tuple2` and `tuple3`, these instances and together with some other new instances for `tuple`s are not provided by `cats.std.tuple` (through inheriting the instance trait defined in algebra 0.4.2). | |||
There was a problem hiding this comment.
This is a typo right? Should be "are now provided by" right?
| @@ -6,10 +6,12 @@ Version 0.5.0 is the fifth release. | |||
|
|
|||
| This release includes some API changes: | |||
|
|
|||
| `cats.laws.discipline.eq` no longer provides `Eq` instances for `tuple2` and `tuple3`, these instances and together with some other new instances for `tuple`s are now provided by `cats.std.tuple` (through inheriting the instance trait defined in algebra 0.4.2). | |||
There was a problem hiding this comment.
Nitpicky but could you capitalize Tuple2, etc.? The formatting and context makes it look like you're referring to real types.
|
👍, thanks @kailuowang! |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.