Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Traverse[Try] #1083

Merged
merged 2 commits into from
Jun 5, 2016
Merged

Add Traverse[Try] #1083

merged 2 commits into from
Jun 5, 2016

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Jun 1, 2016

Resolves #1081

@codecov-io
Copy link

codecov-io commented Jun 1, 2016 •
edited
Loading

Current coverage is 88.16%

Merging #1083 into master will increase coverage by <.01%

@@             master      #1083   diff @@
==========================================
  Files           224        224          
  Lines          2842       2847     +5   
  Methods        2785       2790     +5   
  Messages          0          0          
  Branches         52         52          
==========================================
+ Hits           2505       2510     +5   
  Misses          337        337          
  Partials          0          0

Sunburst

Powered by Codecov. Last updated by cfe283d...a38b3a9

@non
Copy link
Contributor

non commented Jun 2, 2016

👍

@ceedubs
Copy link
Contributor Author

ceedubs commented Jun 2, 2016

@johnynek would you be interested in reviewing this one, since you recently submitted #1059?

johnynek
johnynek reviewed Jun 2, 2016
View reviewed changes
core/src/main/scala/cats/std/try.scala
* A `Failure` can be statically typed as `Try[A]` for all `A`, because it
* does not actually contain an `A` value (as `Success[A]` does).
*/
def castFailure[A](f: Failure[_]): Try[A] = f.asInstanceOf[Try[A]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth it to put an @inline here? I don't actually know how effective that is, but it seems like a candidate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. That seems reasonable to me.

@johnynek
Copy link
Contributor

johnynek commented Jun 2, 2016

👍 modulo the minor comment on @inline

@ceedubs
Copy link
Contributor Author

ceedubs commented Jun 5, 2016

I've updated with @inline

@johnynek
Copy link
Contributor

johnynek commented Jun 5, 2016

👍

1 similar comment
@adelbertc
Copy link
Contributor

👍

@adelbertc adelbertc merged commit 00839fb into typelevel:master Jun 5, 2016
@stew stew removed the in progress label Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ceedubs @codecov-io @non @johnynek @adelbertc @stew