From 140ee0f5dbfcf93f6225081b79c70abc92b55ace Mon Sep 17 00:00:00 2001 From: Cody Allen Date: Tue, 17 Apr 2018 06:27:03 -0700 Subject: [PATCH] Change override of neqv in Order Based on the discussion in #2230. --- kernel/src/main/scala/cats/kernel/Order.scala | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/src/main/scala/cats/kernel/Order.scala b/kernel/src/main/scala/cats/kernel/Order.scala index 4ddff806d6..595e385a7a 100644 --- a/kernel/src/main/scala/cats/kernel/Order.scala +++ b/kernel/src/main/scala/cats/kernel/Order.scala @@ -56,9 +56,13 @@ trait Order[@sp A] extends Any with PartialOrder[A] { self => /** * Returns true if `x` != `y`, false otherwise. + * + * Note: this default implementation provided by [[Order]] is the same as the + * one defined in [[Eq]], but for purposes of binary compatibility, the + * override in [[Order]] has not yet been removed. + * See [[https://github.com/typelevel/cats/pull/2230#issuecomment-381818633 this discussion]]. */ - override def neqv(x: A, y: A): Boolean = - compare(x, y) != 0 + override def neqv(x: A, y: A): Boolean = !eqv(x, y) /** * Returns true if `x` <= `y`, false otherwise.