Added EmptyK instance for Map #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3677 +/- ##
==========================================
- Coverage 90.24% 90.21% -0.04%
==========================================
Files 391 391
Lines 8866 8869 +3
Branches 251 252 +1
==========================================
Hits 8001 8001
- Misses 865 868 +3 |
larsrh
approved these changes
Dec 6, 2020
|
Thanks! |
joroKr21
reviewed
Feb 13, 2021
| @@ -21,7 +21,7 @@ object Empty extends EmptyInstances0 { | |||
| def apply[A](a: => A): Empty[A] = | |||
| new Empty[A] { lazy val empty: A = a } | |||
|
|
|||
| def fromEmptyK[F[_], T](implicit ekf: EmptyK[F]): Empty[F[T]] = ekf.synthesize[T] | |||
| implicit def fromEmptyK[F[_], T](implicit ekf: EmptyK[F]): Empty[F[T]] = ekf.synthesize[T] | |||
There was a problem hiding this comment.
Looks like kittens can't handle this: typelevel/kittens#299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the missing
EmptyKinstance for aMap.Also, I made the
Empty.fromEmptyKfunction implicit. I don't know why it was not marked as implicit, and it looks like it is a pretty safe change. This change automatically added anEmptyinstance for aMaptoo.