MySQL java.time instances #2011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/ci.yml # build.sbt # modules/core/src/main/scala/doobie/util/analysis.scala
jatcwang
force-pushed
the
mysql_2
branch
2 times, most recently
from
086c6ca
to
5418d58
Compare
Due to inconsistencies between various database and JDBC drivers on how they report the JDBC column/parameter type (JdbcType) and vendor type name, we separate the java.time instances and put them under the database-specific import. Implementation changes: - Analysis now - When defining a Put/Get using Basic.one etc, user can now pass in an optional checkedVendorTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1791.
A follow up PR will move JdbcType "tweaks" (
tweakJdbcType) into the Meta instance definitions themselves which will allow users to add their tweak the returned JdbcType from their database drivers. Because of this, this PR moves towards the direction of putting the java.time instances in their DB-specific import.