Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict evaluation option #738

Merged
merged 3 commits into from
Apr 16, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Show all log levels enabled in strict implementation & fix typo
ant8e committed Mar 27, 2023
commit 8bf252741cb3296e847a127823b48e100a1f7042
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ object NoOpLogger {
def impl[F[_]: Applicative] = impl_[F](evaluateArgs = false)

private[noop] def impl_[F[_]: Applicative](evaluateArgs: Boolean): SelfAwareStructuredLogger[F] =
if (evaluateArgs) stricImpl else lazyImpl
if (evaluateArgs) strictImpl else lazyImpl

private def lazyImpl[F[_]: Applicative] = new SelfAwareStructuredLogger[F] {

@@ -67,19 +67,19 @@ object NoOpLogger {
unit
}

private def stricImpl[F[_]: Applicative] = new SelfAwareStructuredLogger[F] {
private def strictImpl[F[_]: Applicative] = new SelfAwareStructuredLogger[F] {

val no: F[Boolean] = Applicative[F].pure(false)
val yes: F[Boolean] = Applicative[F].pure(true)
def void(arg: => Any): F[Unit] = Applicative[F].pure {
val _ = arg
()
}

@inline override def isTraceEnabled: F[Boolean] = no
@inline override def isDebugEnabled: F[Boolean] = no
@inline override def isInfoEnabled: F[Boolean] = no
@inline override def isWarnEnabled: F[Boolean] = no
@inline override def isErrorEnabled: F[Boolean] = no
@inline override def isTraceEnabled: F[Boolean] = yes
@inline override def isDebugEnabled: F[Boolean] = yes
@inline override def isInfoEnabled: F[Boolean] = yes
@inline override def isWarnEnabled: F[Boolean] = yes
@inline override def isErrorEnabled: F[Boolean] = yes
@inline override def trace(t: Throwable)(msg: => String): F[Unit] = void(t)
@inline override def trace(msg: => String): F[Unit] = void(msg)
@inline override def trace(ctx: Map[String, String])(msg: => String): F[Unit] = void(msg)