-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPDX headers? #72
Comments
We should crap or get off the pot on this one before we migrate too many more projects. |
I would merge a PR that makes this change 👍 With that said, once we have a |
I'm less worried about being able to do it and more worried about defaults churn now that this has been rolled out to more than a couple obscure repositories. |
Fair enough. But it would already be a sort of defaults churn since for most/all repos the de-facto default seems to be non-SPDX headers. |
Yeah, that's a fair point. I was focued on the repos that have no headers. There should be a high bar to changing defaults, and this appears to be one that only I care about. |
I had a quick look at this one and it seems like it could be awkward as I don't think sbt-header will regenerate existing headers into the new style in All I did to test this was to add the |
This is when http4s migrated from SPDX to the default: https://github.com/Banno/mobile-data-services/pull/8954. I wish I remembered whether that regeneration commit just worked or if I did black sed magic to strip the original header before recreating. 🤔 |
I have swallowed a bunch of defaults I don't like in the interest of comity, but typelevel/jawn#402 has me wondering about whether this is our opportunity to wave the flag for SPDX. It accomplishes the same, is more terse, and is machine readable. SPDX is good.
The text was updated successfully, but these errors were encountered: