Update otel4s to 0.5.0-RC2, use otel4s-sdk in tests
#1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
commented
Feb 28, 2024
| private var ioTracerFinalizer: IO[Unit] = _ | ||
|
|
||
| implicit lazy val ioTracer: Tracer[IO] = { | ||
| val tracerAndFinalizer = tracerResource.allocated.unsafeRunSync() |
There was a problem hiding this comment.
We cannot use unsafeRunSync() on Native and Scala.js platforms. So the tests will be slightly more verbose.
|
Hopefully, we will get a release this week. Here are the details: typelevel/otel4s#511 (comment). |
|
Awesome, thanks! +1 on including in 0.5.0 release. |
iRevive
force-pushed
the
otel4s-sdk
branch
2 times, most recently
from
865c779
to
63c83a3
Compare
iRevive
changed the title
otel4s-sdk across all platforms in testsotel4s-sdk in tests
|
I updated otel4s to |
|
Awesome, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
otel4s-sdk-*modules provide a cross-platform implementation of the SDK API.The traces seem consistent across platforms:
JVM
JS